1245673 - Remove useless NS_INT32_TO_PTR from nsTraceRefCnt

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Andrew McCreight [:mccr8]]

DumpSerialNumbers contains this code:
   fprintf(outputFile, "%" PRIdPTR
           " @%p (%d references)\n",
           record->serialNumber,
           NS_INT32_TO_PTR(aHashEntry->key),
           record->refCount);

aHashEntry is a PLHashEntry, so key has type |const void*|.

The key is set in this line:
    PL_HashTableRawAdd(gSerialNumbers, hep, HashNumber(aPtr),
                       aPtr, static_cast<void*>(record));

The key is |aPtr|, which has type |void*|. Thus the NS_INT32_TO_PTR() call is unnecessary. It converts from void* to intptr_t to void*.

Comment 1

[Andrew McCreight [:mccr8]]

Attachment: Remove useless NS_INT32_TO_PTR from DumpSerialNumbers.

I did some light local testing and it seems okay. I didn't test the dynamic casting part but whatever.

Comment 2

[Masatoshi Kimura [:emk]]

NS_INT32_TO_PTR should be strongly typed (at least when using C++) to avoid similar problems in the future...

Comment 3

[Nathan Froyd [:froydnj]]

Comment on attachment 8715546 [details] [diff] [review]
Remove useless NS_INT32_TO_PTR from DumpSerialNumbers.

Review of attachment 8715546 [details] [diff] [review]:
-----------------------------------------------------------------

r=me assuming gcc/clang don't choke on passing |const void*| to %p.  (They shouldn't, but you never know...)

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/484a836a04c1

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/484a836a04c1