Closed Bug 1245836 Opened 4 years ago Closed 4 years ago

--disable-compile-environment for thunderbird doesn't find nsinstall.py

Categories

(Firefox Build System :: General, defect)

defect
Not set
normal

Tracking

(firefox47 fixed)

RESOLVED FIXED
mozilla47
Tracking Status
firefox47 --- fixed

People

(Reporter: Pike, Assigned: Pike)

References

Details

Attachments

(1 file, 1 obsolete file)

Attached patch is this any good? (obsolete) — Splinter Review
I've just learned that using --disable-compile-environment doesn't find nsinstall.py for thunderbird.

Lack of 'mozilla' in the path is the culprit.

Mike, the attached patch is roughly tested, no idea if this change would be a good idea or not?
Attachment #8715816 - Flags: feedback?(mh+mozilla)
we _badly_ want this for an issue currently occuring on our beta build
Blocks: 1245853
Comment on attachment 8715816 [details] [diff] [review]
is this any good?

Review of attachment 8715816 [details] [diff] [review]:
-----------------------------------------------------------------

::: configure.in
@@ -781,4 @@
>  fi
>  
>  if test -z "$COMPILE_ENVIRONMENT"; then
> -    NSINSTALL_BIN='$(PYTHON) $(topsrcdir)/config/nsinstall.py'

Try MOZILLA_DIR
Attachment #8715816 - Flags: feedback?(mh+mozilla)
Attached patch Use MOZILLA_DIRSplinter Review
Assignee: nobody → l10n
Attachment #8715816 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #8719490 - Flags: review?(mh+mozilla)
Attachment #8719490 - Flags: review?(mh+mozilla) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/c097541033bc
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.