--disable-compile-environment for thunderbird doesn't find nsinstall.py

RESOLVED FIXED in Firefox 47

Status

RESOLVED FIXED
3 years ago
7 months ago

People

(Reporter: Pike, Assigned: Pike)

Tracking

unspecified
mozilla47

Firefox Tracking Flags

(firefox47 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

3 years ago
Created attachment 8715816 [details] [diff] [review]
is this any good?

I've just learned that using --disable-compile-environment doesn't find nsinstall.py for thunderbird.

Lack of 'mozilla' in the path is the culprit.

Mike, the attached patch is roughly tested, no idea if this change would be a good idea or not?
Attachment #8715816 - Flags: feedback?(mh+mozilla)

Comment 1

3 years ago
we _badly_ want this for an issue currently occuring on our beta build

Updated

3 years ago
Blocks: 1245853
Comment on attachment 8715816 [details] [diff] [review]
is this any good?

Review of attachment 8715816 [details] [diff] [review]:
-----------------------------------------------------------------

::: configure.in
@@ -781,4 @@
>  fi
>  
>  if test -z "$COMPILE_ENVIRONMENT"; then
> -    NSINSTALL_BIN='$(PYTHON) $(topsrcdir)/config/nsinstall.py'

Try MOZILLA_DIR
Attachment #8715816 - Flags: feedback?(mh+mozilla)
(Assignee)

Comment 3

3 years ago
Created attachment 8719490 [details] [diff] [review]
Use MOZILLA_DIR
Assignee: nobody → l10n
Attachment #8715816 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #8719490 - Flags: review?(mh+mozilla)
Attachment #8719490 - Flags: review?(mh+mozilla) → review+
(Assignee)

Updated

3 years ago
Keywords: checkin-needed

Comment 5

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/c097541033bc
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox47: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla47

Updated

7 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.