Closed
Bug 1245836
Opened 9 years ago
Closed 9 years ago
--disable-compile-environment for thunderbird doesn't find nsinstall.py
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(firefox47 fixed)
RESOLVED
FIXED
mozilla47
| Tracking | Status | |
|---|---|---|
| firefox47 | --- | fixed |
People
(Reporter: Pike, Assigned: Pike)
References
Details
Attachments
(1 file, 1 obsolete file)
|
557 bytes,
patch
|
glandium
:
review+
|
Details | Diff | Splinter Review |
I've just learned that using --disable-compile-environment doesn't find nsinstall.py for thunderbird.
Lack of 'mozilla' in the path is the culprit.
Mike, the attached patch is roughly tested, no idea if this change would be a good idea or not?
Attachment #8715816 -
Flags: feedback?(mh+mozilla)
|
||
Comment 1•9 years ago
|
||
we _badly_ want this for an issue currently occuring on our beta build
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8715816 [details] [diff] [review]
is this any good?
Review of attachment 8715816 [details] [diff] [review]:
-----------------------------------------------------------------
::: configure.in
@@ -781,4 @@
> fi
>
> if test -z "$COMPILE_ENVIRONMENT"; then
> - NSINSTALL_BIN='$(PYTHON) $(topsrcdir)/config/nsinstall.py'
Try MOZILLA_DIR
Attachment #8715816 -
Flags: feedback?(mh+mozilla)
|
Assignee | |
Comment 3•9 years ago
|
||
Assignee: nobody → l10n
Attachment #8715816 -
Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #8719490 -
Flags: review?(mh+mozilla)
|
|
||
Updated•9 years ago
|
Attachment #8719490 -
Flags: review?(mh+mozilla) → review+
|
|
Assignee | |
Updated•9 years ago
|
Keywords: checkin-needed
Keywords: checkin-needed
|
||
Comment 5•9 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox47:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
|
||
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•