1245939 - Text selection action bar overflow menu disappears when tapping on it

Status: RESOLVED WORKSFORME

(Firefox for Android Graveyard :: Text Selection, defect)

Description

[:Margaret Leibovic]

From bug 1245831:

I also just tried tapping on an input box on a website, and I saw the overflow menu appear in the action bar. Then when I tapped on it, it went away and fewer icons were shown. But I can't reproduce that issue on Aurora, so I think this is a recent regression.

I could only reproduce this in Nightly, so I suspect it's a regression.

Capella, do you have any ideas what could be going on here?

Comment 1

[Mark Capella [:capella]]

Maybe more STR/details will help me, the recent changes have thrown my mental code-flow expectations :)

aiui starting today in nightly builds, we no longer support tapping into an <input> to display the ActionBar.

Perhaps you mean long-tapping to open the ActionBar, and subsequent tapping the its 3-dot overflow menu icon (distinguishable from the Awesomebar 3-dot as visibly larger), failed to dropdown the overlow options, but simply removed itself as a visible ActionBar option (?)

Do you recall the site? Did you notice the options then available? Perhaps the selection changed down to caret-style and the ActionBar failed to close, but then displayed new, abbreviated options accordingly?

Comment 2

[:Margaret Leibovic]

This just happened to me following the STR from bug 1245831.

1) Visit imdb.com
2) Type some text in search box
3) Long tap on text to bring up action bar
4) Tap on 3-dot menu in action bar

Comment 3

[:Margaret Leibovic]

This won't be an issue anymore if we fix bug 1171110, but if we're not going to fix that soon, we'll need to deal with this.

Comment 4

[:Margaret Leibovic]

Sebastian, this might be something to look into if we can't land bug 1171110 soon.

Comment 5

[Sebastian Kaspari (:sebastian; :pocmo)]

We will only be able to support the floating toolbar on android 6+ - So I guess we will have to look into this.

Comment 6

[Mark Capella [:capella]]

Drive by, you might want to keep in mind the main part of the fix in bug 1245831, I thought these were related.

Comment 7

[Sebastian Kaspari (:sebastian; :pocmo)]

I'm unable to reproduce this so far - However it's possible to get an empty overflow menu (filed bug 1266340)

Comment 8

[Sebastian Kaspari (:sebastian; :pocmo)]

Tried again and can't reproduce it (With Sony Z3C). However I'd be happy to mentor someone who can.

(In reply to Mark Capella [:capella] from comment #6)
> Drive by, you might want to keep in mind the main part of the fix in bug
> 1245831, I thought these were related.

Do you think bug 1245831 could have fixed that? I looked at the patch and can't come up with a theory how this should have triggered this bug?