1245950 - Have nsGlobalWindow privately inherit from nsIDOMWindowInternal

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Attachment: Patch

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8715956 [details] [diff] [review]
Patch

Not quite sure why, but if this forces us to use newer stuff and now the legacy interfaces, fine.

I'm not too happy with
-    nsCOMPtr<nsIDOMWindow> window = do_QueryReferent(mWindow);
+    nsCOMPtr<nsISupports> window = do_QueryReferent(mWindow);
     if (!skipNukeCrossCompartment && window) {
-      nsGlobalWindow* win = static_cast<nsGlobalWindow*>(window.get());
+      nsGlobalWindow* win = nsGlobalWindow::FromSupports(window);
Would be nicer to QR to some window specific interface but fine.

Comment 2

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5aaf42e26bf1

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8de87e81529a

Comment 4

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/5aaf42e26bf1
https://hg.mozilla.org/mozilla-central/rev/8de87e81529a