1245955 - incorrect GLIBC check in prnetdb.c defines _PR_HAVE_GETPROT_R

Status: UNCONFIRMED

(NSPR :: NSPR, defect)

Description

[Andrew Cagney]

User Agent: Mozilla/5.0 (X11; Fedora; Linux x86_64; rv:43.0) Gecko/20100101 Firefox/43.0
Build ID: 20151229124055

Steps to reproduce:

Compile nspr on OpenWRT (a Linux variant) that does not have GLIBC and does not have the re-entrant getprotobyname_r and getprotobynumber_r


Actual results:

Here's a patch to nspr/pr/src/misc/prnetdb.c that hopefully illustrates the problem:

 #if defined(SOLARIS) || (defined(BSDI) && defined(_REENTRANT)) \
 	|| (defined(LINUX) && defined(_REENTRANT) \
-        && !(defined(__GLIBC__) && __GLIBC__ >= 2) \
+        && defined(__GLIBC__) && !(__GLIBC__ >= 2)  \
         && !defined(ANDROID))
 #define _PR_HAVE_GETPROTO_R
 #define _PR_HAVE_GETPROTO_R_POINTER

On linux systems where __GLIBC__ is not defined at all (OpenWRT uses the musl libc library) _RP_HAVE_GET_PROTO_R is being defined.


Expected results:

See above patch for possible fix.

I've got to wonder if !defined(ANDROID) was a workaround.