Integrate Kannan and Jonas FlyWeb code

RESOLVED FIXED

Status

()

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: djvj, Unassigned)

Tracking

(Blocks: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments, 2 obsolete attachments)

(Reporter)

Description

3 years ago
Jonas has been working on the server implementation, and I've been working on the discovery/naming/transport layer implementation.

This has led to a fragmentation of similar objects which should be unified into one set of implementation objects.
(Reporter)

Comment 1

3 years ago
Created attachment 8715987 [details] [diff] [review]
1-move-flyweb-discovery-manager-into-flyweb-service.patch

This patch moves most of the FlyWebDiscoveryManager implementation into FlyWebService.  FlyWebDiscoveryManager becomes a thin forwarder object around FlyWebService.
(Reporter)

Comment 2

3 years ago
Created attachment 8716467 [details] [diff] [review]
2-refactor-publish-server-implementation.patch

Refactors the publish server implementation to separate the frontend JS object from the (potentially many, eventually) backend implementation objects.

Not tested.  Probably has bugs, probably will crash.

Sicking: can you walk me through how you smoke-test your flyweb:// channel/protocol implementation so far?  Do you have some test pages somewhere?  I need to go through this to test/debug the code.
(Reporter)

Comment 3

3 years ago
Forgot to ni, so re-posting comment:


Sicking: can you walk me through how you smoke-test your flyweb:// channel/protocol implementation so far?  Do you have some test pages somewhere?  I need to go through this to test/debug the code.
Flags: needinfo?(jonas)
(Reporter)

Comment 4

3 years ago
Created attachment 8718554 [details] [diff] [review]
1-move-flyweb-discovery-manager-into-flyweb-service.patch

Updated patch.
Attachment #8715987 - Attachment is obsolete: true
(Reporter)

Comment 5

3 years ago
Created attachment 8718555 [details] [diff] [review]
2-refactor-publish-server-implementation.patch

Updated patch.
Attachment #8716467 - Attachment is obsolete: true
(Reporter)

Comment 6

3 years ago
Created attachment 8718556 [details] [diff] [review]
3-add-mdns-advertising.patch

This makes it so that servers published using |navigator.publishServer| are advertised via the mdns backend.
You need to log in before you can comment on or make changes to this bug.