1246123 - Can't drag the window using the empty space on the bookmarks bar anymore when using a lightweight theme

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[:Gijs (he/him)]

This regressed because I didn't foresee that the changes from bug 1241275 meant that the 'no-drag' on the toolbaritem would prevent anything in its region from being dragged, even the empty space in the descendant scrollbox when that was explicitly marked 'drag'.

It seems like it would make sense to override the toolbaritem styling of 'no-drag' for the bookmarks toolbar item instead (when using a lwt and not in customization mode). The bookmarks themselves are toolbarbuttons, so they will take care of themselves.

Comment 1

[:Gijs (he/him)]

Attachment: MozReview Request: Bug 1246123 - fix draggability of empty bookmark space for lightweight themes, r?felipe

Review commit: https://reviewboard.mozilla.org/r/33757/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/33757/

Comment 2

[arni2033]

I still can't understand how that stuff was implemented w/o designer's review... BTW, Is there a
plan to allow "powerful" lwthemes to cancel this offending drag feature?  (a good question actually)

Comment 3

[:Gijs (he/him)]

(In reply to arni2033 from comment #2)
> I still can't understand how that stuff was implemented w/o designer's
> review...

This is not really very constructive feedback. For which part should I have gotten "designer's review" in your opinion? Why?

Bug 1219215 shouldn't have materially changed behaviour on the default theme (and this bug is about the one issue I know about for lightweight themes). It also brought the devedition theme in line with the default theme. It fixed a bug about the behaviour when closing tabs. None of those (lack of) changes seemed controversial or in need of a "designer's review".

The original behaviour of draggable lightweight theme toolbars dates back to Firefox 4 or earlier, and I would imagine it was proposed by UX at that time, or done simply because it made sense for glassed or lwt toolbars - the area between those toolbars and the titlebar was continuous. In any case, if you want it reviewed, ping :phlsa with details on one of the other bugs you filed about things you don't like about this behaviour, or write to firefox-dev.

(In reply to arni2033 from comment #2)
> Is there a plan to allow "powerful" lwthemes

To the best of my knowledge plans for more powerful lwthemes haven't been made yet, so "no/not yet". However, now that 1219215 has landed you can deal with the issue using only userChrome CSS, which was hard/impossible before.

Comment 4

[:Felipe Gomes (needinfo for replies!)]

Comment on attachment 8716262 [details]
MozReview Request: Bug 1246123 - fix draggability of empty bookmark space for lightweight themes, r?felipe

https://reviewboard.mozilla.org/r/33757/#review30615

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/1e6bb5a9d9e2

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/1e6bb5a9d9e2

Comment 7

[Mihai Boldan, Desktop QA [:mboldan]]

I managed to reproduce this issue on Firefox47.0a1 (2016-02-05) and on Windows10 x64.
Here are the results, after verifying the issue on Firefox 47.0b8, Firefox 48.0a2 (2016-05-25) and on Firefox 49.0a1 (2016-05-25) across platforms(1):
- On Windows, the issue is no longer reproducible
- On Ubuntu the issue is still reproducible on all tested builds
- On Mac, the window can be dragged by using the space on the bookmarks bar, even if the default theme is installed 

Should I log separate bugs for the issues from Ubuntu and Mac OS's?

(1)Windows 10 x64, Mac OS X 10.10.5, Ubuntu 14.04 x64

Comment 8

[:Gijs (he/him)]

(In reply to Mihai Boldan, QA [:mboldan] from comment #7)
> I managed to reproduce this issue on Firefox47.0a1 (2016-02-05) and on
> Windows10 x64.
> Here are the results, after verifying the issue on Firefox 47.0b8, Firefox
> 48.0a2 (2016-05-25) and on Firefox 49.0a1 (2016-05-25) across platforms(1):
> - On Windows, the issue is no longer reproducible
> - On Ubuntu the issue is still reproducible on all tested builds
> - On Mac, the window can be dragged by using the space on the bookmarks bar,
> even if the default theme is installed 
> 
> Should I log separate bugs for the issues from Ubuntu and Mac OS's?
> 
> (1)Windows 10 x64, Mac OS X 10.10.5, Ubuntu 14.04 x64

No, the fix is Windows-specific. Thanks.