1246168 - When reinstalling/updating Hello Tools > Start a conversation is repeated

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect, P2)

Description

[Ian Bicking (:ianbicking)]

I updated the add-on twice in one Firefox session and got three copies of the "Start a conversation..." item in my Tools menu.

Comment 1

[Mike de Boer [:mikedeboer]]

This is on beta, right?

Comment 2

[Mark Banner (:standard8)]

removeMenuItem isn't being called in bootstrap.js. I've a feeling it disappeared along the line somewhere...

Comment 3

[Ian Bicking (:ianbicking)]

This was on 46 Dev Edition

Comment 4

[Mike de Boer [:mikedeboer]]

(In reply to Mark Banner (:standard8) from comment #2)
> removeMenuItem isn't being called in bootstrap.js. I've a feeling it
> disappeared along the line somewhere...

According to git history, it was never hooked up in the first place!

Comment 5

[GitHub Autolander Bot]

Attachment: [loop] Standard8:bug-1246168-cleanup > mozilla:master

Comment 6

[Mark Banner (:standard8)]

Comment on attachment 8717340 [details] [review]
[loop] Standard8:bug-1246168-cleanup > mozilla:master

(In reply to Mike de Boer [:mikedeboer] from comment #4)
> (In reply to Mark Banner (:standard8) from comment #2)
> > removeMenuItem isn't being called in bootstrap.js. I've a feeling it
> > disappeared along the line somewhere...
> 
> According to git history, it was never hooked up in the first place!

Interestingly, https://hg.mozilla.org/releases/mozilla-aurora/rev/ac9c0f02ef33 has this change in. So I guess we must have had a merge issue or something when we landed it into github.

Anyway, this should cleanup the menu option, and keep things tidy.

Comment 7

[Mark Banner (:standard8)]

https://github.com/mozilla/loop/commit/de6af7e74645691428ac6f5fad0523346e4292ef