Closed
Bug 1246191
Opened 9 years ago
Closed 9 years ago
Users can't view the list of workerTypes
Categories
(Taskcluster :: Services, defect)
Taskcluster
Services
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: dustin, Assigned: jhford)
References
Details
Attachments
(1 file)
Users implementing new task types don't have any way to view the list of available workerTypes. This is basically the only read-only call in TC that is protected by scopes (aside from secrets, obviously).
This is protected because there are secrets embedded in the workerType definitions. It wouldn't be too hard to return a subset of the workerType definition in the `workerTypes` method, and only include the secrets in the `workerType` method -- or even to add a separate `getSecrets` method.
Comment 1•9 years ago
|
||
I'd propose instead that the worker types only refer to keys of the secrets store, not values, and this way can become public (see bug 1246620).
Comment 2•9 years ago
|
||
From irc: Let's patch listWorkerTypes so that it doesn't require a scope.
Flags: needinfo?(jhford)
Reporter | ||
Comment 3•9 years ago
|
||
Once that's done, pass the bug to me and I'll update tools to show only workerType names (and pending tasks) for each, when aws-provisioner:view-worker:<workerType> is not available.
Assignee | ||
Comment 4•9 years ago
|
||
Flags: needinfo?(jhford)
Attachment #8722525 -
Flags: review?(jopsen)
Updated•9 years ago
|
Attachment #8722525 -
Flags: review?(jopsen) → review+
Comment 5•9 years ago
|
||
This is merged.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Updated•9 years ago
|
Assignee: nobody → jhford
Updated•6 years ago
|
Component: AWS-Provisioner → Services
You need to log in
before you can comment on or make changes to this bug.
Description
•