1246232 - Remove "Add to Reading List" from context menus when long-pressing on link

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Comment 1

[Andrzej Hunt :ahunt]

Attachment: MozReview Request: Bug 1246232 - Remove "add to reading list" from link-long-press context menu r?liuche

Review commit: https://reviewboard.mozilla.org/r/38581/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/38581/

Comment 2

[Chenxia Liu [:liuche]]

Comment on attachment 8727653 [details]
MozReview Request: Bug 1246232 - Remove "add to reading list" from link-long-press context menu r?liuche

https://reviewboard.mozilla.org/r/38581/#review35193

::: mobile/android/chrome/content/browser.js
(Diff revision 1)
> -            type: "Reader:AddToList",

Do we send this Reader:AddToList message anywhere else? If so, remove that from any Android listeners (and any strings, toasts, etc that might get popped up to confirm). I feel like there might be another message that gets sent back...but I guess it depends on if we are keeping the "+readinglist" icon in the menu.

::: mobile/android/locales/en-US/chrome/browser.properties
(Diff revision 1)
> -contextmenu.addToReadingList=Add to Reading List

Nice. If this needs to be uplifted, you might need to do this in a separate patch (so we don't break the "no string changes rule" which includes removing strings I guess? You could double check that with someone).

Comment 3

[:Margaret Leibovic]

(In reply to Chenxia Liu [:liuche] from comment #2)

> ::: mobile/android/locales/en-US/chrome/browser.properties
> (Diff revision 1)
> > -contextmenu.addToReadingList=Add to Reading List
> 
> Nice. If this needs to be uplifted, you might need to do this in a separate
> patch (so we don't break the "no string changes rule" which includes
> removing strings I guess? You could double check that with someone).

Let's not uplift any of this work. The reading list migration work should all happen in 48.

Comment 4

[Andrzej Hunt :ahunt]

https://hg.mozilla.org/integration/fx-team/rev/64e9f80e3be5ca554e3983f12025add4ac220241
Bug 1246232 - Remove "add to reading list" from link-long-press context menu r=liuche

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/64e9f80e3be5

Comment 6

[Teodora Vermesan (:TeoVermesan)]

"Add to Reading List" is not an option anymore in context menus when long-pressing on a link

Verified as fixed using:
Device: Nexus 6 (Android 6.0) and Nexus 7 (Android 5.1)
Build: Firefox for Android 48.0a1 (2016-04-10)