1246276 - Notification/Push Permission might be interpreted as a warning logo

Status: VERIFIED FIXED

(Firefox :: General, defect)

Description

[:Harald Kirschner :digitarald]

Attachment: Notification permission icon looking like a warning

A partner asked why the permission icon is a warning and I agree that this might be confusing to users. Compared to other permission icons it looks rather dangerous.

Comment 1

[:Harald Kirschner :digitarald]

Attachment: Geolocation icon

Compared, the Geolocation icon looks more inviting

Comment 2

[:Harald Kirschner :digitarald]

Jeff for product input

Comment 3

[Jeff Griffiths (:canuckistani) (:⚡︎)]

Attachment: Chrome notifications prompt

I think we're specifically talking about us of the exclamation mark? Needinfo'ing Philipp.

Philipp, opinons on whether the exclamation mark is appropriate here? Do we have any user testing that either supports or mitigates Harald's hypothesis?

Comment 4

[bbell]

Attachment: example.png

Here's the replacement (example). I need a list of the currently used assets so I can get you drop-in replacements.

Comment 5

[(Currently slow to respond) Philipp Sackl [:phlsa] (Firefox UX) please use needinfo]

Clearing my NI as Bryan has taken this bug already.
The new icon is definitely better and less ambiguous.

Comment 6

[Jared Wein [:jaws] (please needinfo? me)]

Brian, the file that needs updating is located at /browser/themes/shared/web-notifications-tray.svg in mozilla-central.

Comment 7

[Jared Wein [:jaws] (please needinfo? me)]

Bryan*

Comment 8

[bbell]

Attachment: web-notification-tray.svg

here's a replacement style-icon-notification icon

Comment 9

[bbell]

Attachment: web-notifications-icon.svg

here's the other icon

Comment 10

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: MozReview Request: Bug 1246276 - Notification/Push Permission might be interpreted as a warning logo. r?shorlander

Review commit: https://reviewboard.mozilla.org/r/36261/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/36261/

Comment 11

[Jared Wein [:jaws] (please needinfo? me)]

Tim, I'm having issues getting the web-notifications-tray.svg to display properly in the location bar. Can you look at the SVG and see what I'm doing wrong there? You can use http://people.mozilla.org/~ewong2/push-notification-test/ to test this patch.

Comment 12

[Tim Nguyen :ntim]

I think the SVG is invisible, because the width and height attributes are missing from the root element. I can't test this solution right now since my wifi is very slow (and I can't import the patch), but I'll test tonight once I'm back home (unless you get to it before me :) ).

Comment 13

[Stephen Horlander [:shorlander]]

(In reply to Tim Nguyen [:ntim] from comment #12)
> I think the SVG is invisible, because the width and height attributes are
> missing from the root element. I can't test this solution right now since my
> wifi is very slow (and I can't import the patch), but I'll test tonight once
> I'm back home (unless you get to it before me :) ).

Yeah the viewbox is wrong setting it to half the size:

<svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" width="48" height="16" viewBox="0 0 96 32">

Should be 1 to 1:

<svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" width="48" height="16" viewBox="0 0 48 16">

Comment 14

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8722833 [details]
MozReview Request: Bug 1246276 - Notification/Push Permission might be interpreted as a warning logo. r?shorlander

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/36261/diff/1-2/

Comment 15

[Jared Wein [:jaws] (please needinfo? me)]

Perfect, yeah changing that fixed it.

Comment 16

[Jared Wein [:jaws] (please needinfo? me)]

Thanks Bryan for the icons. I'll assign the bug to myself now so it shows up on my bug tracker and I don't forget about it.

Comment 17

[Jeff Griffiths (:canuckistani) (:⚡︎)]

(In reply to bbell from comment #8)
> Created attachment 8722735 [details]
> web-notification-tray.svg
> 
> here's a replacement style-icon-notification icon

These look great!

Comment 18

[Stephen Horlander [:shorlander]]

Comment on attachment 8722833 [details]
MozReview Request: Bug 1246276 - Notification/Push Permission might be interpreted as a warning logo. r?shorlander

https://reviewboard.mozilla.org/r/36261/#review35569

Looks good to me!

Comment 19

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/b72a92b614bf

Comment 20

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b72a92b614bf

Comment 21

[Paul Silaghi, QA [:pauly]]

Verified fixed FX 48b2 Win 7