1246289 - network panel shows no error for missing file referenced in arguments to serviceWorker.register

Status: REOPENED

(DevTools :: Netmonitor, defect, P3)

Description

[Bill Walker [:bwalker] [@wfwalker]]

STR:

1. as of 2016-02-05, visit https://getts.ro/upup.html

Expected:

network panel will a failure to retrieve https://getts.ro/upup.sw.min.js

Actual:

network panel shows nothing

Comment 1

[Bill Walker [:bwalker] [@wfwalker]]

> network panel will a failure to retrieve https://getts.ro/upup.sw.min.js

that should have read "network panel will show a failure"

Comment 2

[Ben Kelly [:bkelly, not reviewing]]

I don't think network panel shows requests made from within the service worker either.  Alexander, any ideas on how to fix this?

Comment 3

[Marco Castelluccio [:marco]]

Firefox also doesn't show any error in the console, Chrome does.

Comment 4

[Ben Kelly [:bkelly, not reviewing]]

The .register() does reject its promise, though.  Message is like this:

  TypeError: ServiceWorker script at https://blog.wanderview.com/js/upup.sw.min.js for scope https://blog.wanderview.com/js encountered an error during installation.

Comment 5

[Ben Kelly [:bkelly, not reviewing]]

Its unclear to me how many exceptions and promise rejections we should auto-copy to the console.  The script author can decide how to handle them.

Comment 6

[Alexandre Poirot [:ochameau]]

The network panel should track requests being intercepted by the SW and the request being made by the SW.
But it still miss the requests being made to the Service worker *script* itself, which 
https://getts.ro/upup.sw.min.js seems to be.

I highlighted this issue while globally fixing network panel for service worker.
  https://bugzilla.mozilla.org/show_bug.cgi?id=1158264#c35
This issue is that there is no way to identify to which tab a service worker script request is related.
Requests being made to the script itself are global and don't contain any context that may relates to any tab. the nsIHttpChannel object miss some critical bits, it's nsILoadContext should have a associatedWindow or topFrameElement being set by the platform code.

Comment 7

[Alexandre Poirot [:ochameau]]

I don't know if that would be possible to tweak that in
ServiceWorkerScriptCache.cpp
  CompareNetwork::Initialize

The load group seems to be defined over here. Am It correct?
This comments seems to say we try to ensure the nsILoadContext is correct, but it looks like it isn't at the end.
http://mxr.mozilla.org/mozilla-central/source/dom/workers/ServiceWorkerManager.cpp#1805

Comment 9

[Ben Hsu [:HoPang]]

Sorry, I was just marking this bug can be solved together with 1267119 which I currently have a WIP patch to save them both...

Comment 10

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Per Ho-Pang, this depends on SW redesign clientID. We might need more investigation here.

Comment 11

[Hubert Boma Manilla (:bomsy)]

Adding a working STR

1. Go to https://service-worker-register-missing.glitch.me/
2. Open the netmonitor
3. Refresh to see all requests

ER

See 404 request for service worker file sw.js in the netmonitor.

AR

No request for sw.js is displayed in the netmonitor.

Comment 12

[Hubert Boma Manilla (:bomsy)]

Attachment: Chrome SW requests

Adding a screenshot from chrome, showing the request.