Closed Bug 1246311 Opened 8 years ago Closed 8 years ago

Disable async drawing on beta/release

Categories

(Core Graveyard :: Plug-ins, defect)

defect
Not set
normal

Tracking

(firefox45 fixed, firefox46 fixed, firefox47 fixed)

RESOLVED FIXED
mozilla47
Tracking Status
firefox45 --- fixed
firefox46 --- fixed
firefox47 --- fixed

People

(Reporter: billm, Assigned: billm)

Details

Attachments

(1 file)

Attached patch patchSplinter Review
We're pretty sure this is causing bug 1245200, so let's turn it off on beta for now. It's still the #3 plugin crash on Aurora, so we still have some users of the Flash beta on other branches. That should be enough testing for now.
Attachment #8716527 - Flags: review?(dvander)
Comment on attachment 8716527 [details] [diff] [review]
patch

It looks like Flash is crashing a lot because of some code we added to make drawing faster. We believe it's Adobe's issue, but we should turn off this feature to avoid the crashes.

Approval Request Comment
[Feature/regressing bug #]: bug 1217665
[User impact if declined]: plugin crashes
[Describe test coverage new/current, TreeHerder]: most of our tests test this configuration anyway
[Risks and why]: Low risk.
[String/UUID change made/needed]: None.
Attachment #8716527 - Flags: approval-mozilla-beta?
Attachment #8716527 - Flags: approval-mozilla-aurora?
Attachment #8716527 - Flags: review?(dvander) → review+
https://hg.mozilla.org/mozilla-central/rev/4ca883690e2a
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
Comment on attachment 8716527 [details] [diff] [review]
patch

Fix crashes, taking it.
Should be in 45 beta 4.
Attachment #8716527 - Flags: approval-mozilla-beta?
Attachment #8716527 - Flags: approval-mozilla-beta+
Attachment #8716527 - Flags: approval-mozilla-aurora?
Attachment #8716527 - Flags: approval-mozilla-aurora+
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: