Closed
Bug 1246311
Opened 8 years ago
Closed 8 years ago
Disable async drawing on beta/release
Categories
(Core Graveyard :: Plug-ins, defect)
Core Graveyard
Plug-ins
Tracking
(firefox45 fixed, firefox46 fixed, firefox47 fixed)
RESOLVED
FIXED
mozilla47
People
(Reporter: billm, Assigned: billm)
Details
Attachments
(1 file)
1.15 KB,
patch
|
dvander
:
review+
Sylvestre
:
approval-mozilla-aurora+
Sylvestre
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
We're pretty sure this is causing bug 1245200, so let's turn it off on beta for now. It's still the #3 plugin crash on Aurora, so we still have some users of the Flash beta on other branches. That should be enough testing for now.
Attachment #8716527 -
Flags: review?(dvander)
Assignee | ||
Comment 1•8 years ago
|
||
Comment on attachment 8716527 [details] [diff] [review] patch It looks like Flash is crashing a lot because of some code we added to make drawing faster. We believe it's Adobe's issue, but we should turn off this feature to avoid the crashes. Approval Request Comment [Feature/regressing bug #]: bug 1217665 [User impact if declined]: plugin crashes [Describe test coverage new/current, TreeHerder]: most of our tests test this configuration anyway [Risks and why]: Low risk. [String/UUID change made/needed]: None.
Attachment #8716527 -
Flags: approval-mozilla-beta?
Attachment #8716527 -
Flags: approval-mozilla-aurora?
Attachment #8716527 -
Flags: review?(dvander) → review+
Comment 3•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/4ca883690e2a
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
Updated•8 years ago
|
status-firefox45:
--- → affected
status-firefox46:
--- → affected
Comment 4•8 years ago
|
||
Comment on attachment 8716527 [details] [diff] [review] patch Fix crashes, taking it. Should be in 45 beta 4.
Attachment #8716527 -
Flags: approval-mozilla-beta?
Attachment #8716527 -
Flags: approval-mozilla-beta+
Attachment #8716527 -
Flags: approval-mozilla-aurora?
Attachment #8716527 -
Flags: approval-mozilla-aurora+
Assignee | ||
Comment 5•8 years ago
|
||
https://hg.mozilla.org/releases/mozilla-beta/rev/5b27aa97f725
Updated•8 years ago
|
Comment 6•8 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-aurora/rev/657f6bad7af8
Updated•2 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•