1246314 - GeckoProfile.getClientId may leak profile paths

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

We log the exception when we throw which could contain the profile path. This is caused by bug 1205835.

Comment 1

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Let's land with bug 1205835.

Comment 2

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: MozReview Request: Bug 1246314 - Don't log exception when throwing in client ID. r=ahunt

Review commit: https://reviewboard.mozilla.org/r/33865/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/33865/

Comment 3

[Andrzej Hunt :ahunt]

Comment on attachment 8716530 [details]
MozReview Request: Bug 1246314 - Don't log exception when throwing in client ID. r=ahunt

https://reviewboard.mozilla.org/r/33865/#review30499

Looks good to me!

Comment 4

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

https://hg.mozilla.org/integration/fx-team/rev/045eb365dbb061df49299dcc320b1b9b79e7bbc2
Bug 1246314 - Don't log exception when throwing in client ID. r=ahunt

Comment 5

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8716530 [details]
MozReview Request: Bug 1246314 - Don't log exception when throwing in client ID. r=ahunt

This should be uplifted with bug 1205835.

Approval Request Comment
[Feature/regressing bug #]: bug 1205835
[User impact if declined]: Profile paths may be leaked into logcat cases where clientId is null (e.g. bug 1244295)

[Describe test coverage new/current, TreeHerder]: Tested it built locally
[Risks and why]: extremely low – we remove a parameter to a framework function call.

[String/UUID change made/needed]: None

Comment 6

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: Add comment to explain why we don't log exceptions

Comment 7

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8716544 [details] [diff] [review]
Add comment to explain why we don't log exceptions

I was hasty and forgot to add comments.

Comment 8

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

https://hg.mozilla.org/integration/fx-team/rev/103f2dcf2778d0c22db916e96a962bc0d4eb7ac0
Bug 1246314 - Add comment to explain why we don't log exceptions. r=me

Comment 9

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/045eb365dbb0
https://hg.mozilla.org/mozilla-central/rev/103f2dcf2778

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

This (and probably a bunch of the related uplift requests) needs to be rebased to work around the lack of bug 1107811 on the release branches.

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/1645c68fe3a6
https://hg.mozilla.org/releases/mozilla-aurora/rev/cc914fe8173e

Comment 12

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-beta/rev/7acf77df5830
https://hg.mozilla.org/releases/mozilla-beta/rev/17755de487b7

Comment 13

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8716530 [details]
MozReview Request: Bug 1246314 - Don't log exception when throwing in client ID. r=ahunt

michael had my approval. Updating the uplift flags for posterity.
Should be in 45 beta 4