Closed
Bug 1246339
Opened 9 years ago
Closed 9 years ago
Maybe we need also provide a date input for the build selection
Categories
(Testing :: mozregression, defect)
Testing
mozregression
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: sabergeass, Assigned: parkouss)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
When choose date for build, we use date chooser instead of date input to do it now. That's great and awesome and I like it! But I guess we could also offer a date input like before at the same time, because people may need to choose some early builds and they have to keep click the button to choose date they want.
BTW, I found some layout problem for it. You can see the label and combox wasn't on the same line form attachment. :)
Assignee | ||
Comment 1•9 years ago
|
||
Yeah, thanks for raising this bug. I think we should probably change back to use the date line edit, and add a button that would launch a calendar to pick easily a date. That would combine both, in an easy way.
Assignee | ||
Comment 3•9 years ago
|
||
Mikeling, tell me what you think!
This patch brings back the date line edits, and allow the use of the calendar with a small arrow on the right of the widgets.
Attachment #8716617 -
Flags: review?(sabergeass)
Comment on attachment 8716617 [details] [review]
bring back line date edit
This PR looks great to me! r+ for it :)
Attachment #8716617 -
Flags: review?(sabergeass) → review+
Assignee | ||
Comment 5•9 years ago
|
||
Thanks, landed in:
https://github.com/parkouss/mozregression/commit/b83e74e0dad6a7ee912e6161bf5a3cc89da27e2f
https://github.com/mozilla/mozregression/commit/a426006141b2a361b0bc3c4463277fdc459bd285
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•