Closed
Bug 1246345
Opened 8 years ago
Closed 8 years ago
Change description of MIXED_CONTENT_PAGE_LOAD histogram
Categories
(Core :: DOM: Security, defect)
Core
DOM: Security
Tracking
()
RESOLVED
FIXED
mozilla48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: tanvi, Assigned: tanvi)
References
(Blocks 1 open bug)
Details
(Whiteboard: [domsecurity-active])
Attachments
(1 file)
1.17 KB,
patch
|
ttaubert
:
review+
|
Details | Diff | Splinter Review |
The current description doesn't tell us what the values mean: "Accumulates type of content (mixed, mixed passive, unmixed) per page load" Proposed change: "Accumulates type of content per page load (0=no mixed, 1=mixed passive, 2=mixed active, 3=mixed passive and mixed active); non-secure pages would be included in 0" We can leave out the part after the ; if it is too long or too confusing. http://mxr.mozilla.org/mozilla-central/source/toolkit/components/telemetry/Histograms.json#7618
Assignee | ||
Comment 1•8 years ago
|
||
I went with: "Accumulates type of content per page load (0=no mixed or non-secure page, 1=mixed passive, 2=mixed active, 3=mixed passive and mixed active)" http://mxr.mozilla.org/mozilla-central/source/dom/base/nsDocument.cpp#1534
Comment 2•8 years ago
|
||
Comment on attachment 8716580 [details] [diff] [review] Bug1246345.patch Review of attachment 8716580 [details] [diff] [review]: ----------------------------------------------------------------- Yup, that's better :)
Attachment #8716580 -
Flags: review?(ttaubert) → review+
Updated•8 years ago
|
Whiteboard: [domsecurity-active]
Comment 4•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/f95a09068072
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in
before you can comment on or make changes to this bug.
Description
•