1246345 - Change description of MIXED_CONTENT_PAGE_LOAD histogram

Status: RESOLVED FIXED

(Core :: DOM: Security, defect)

Description

[Tanvi Vyas[:tanvi]]

The current description doesn't tell us what the values mean:
"Accumulates type of content (mixed, mixed passive, unmixed) per page load"

Proposed change:
"Accumulates type of content per page load (0=no mixed, 1=mixed passive, 2=mixed active, 3=mixed passive and mixed active); non-secure pages would be included in 0"

We can leave out the part after the ; if it is too long or too confusing.

http://mxr.mozilla.org/mozilla-central/source/toolkit/components/telemetry/Histograms.json#7618

Comment 1

[Tanvi Vyas[:tanvi]]

Attachment: Bug1246345.patch

I went with:
"Accumulates type of content per page load (0=no mixed or non-secure page, 1=mixed passive, 2=mixed active, 3=mixed passive and mixed active)"
 

http://mxr.mozilla.org/mozilla-central/source/dom/base/nsDocument.cpp#1534

Comment 2

[Tim Taubert [:ttaubert] (inactive)]

Comment on attachment 8716580 [details] [diff] [review]
Bug1246345.patch

Review of attachment 8716580 [details] [diff] [review]:
-----------------------------------------------------------------

Yup, that's better :)

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f95a09068072

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f95a09068072