Closed Bug 12465 Opened 25 years ago Closed 25 years ago

nsIRegion needs to be IDL-ified

Categories

(Core Graveyard :: GFX, defect, P3)

Product:
Core Graveyard
Component:
GFX
Type:
defect

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: mikepinkerton, Assigned: kmcclusk)

References

Details

(Whiteboard: [PDT+]) 

I need nsIRegion idl-ified for d&d scripting through JS. There are things in it
that make it not IDL-able such as defining and passing around structs. Maybe
breaking into two separate interfaces (one pure, the other having the extra c++
stuff which JS probably doesn't need anyway) would suffice, but this requires
changing all platform implementations.

This is a blocker for scripting d&d in JS.
Blocks: 11821
sorry about the layout component. there is no GFX component. ;)
Blocks: 11346
Assignee: troy → beard
Component: Layout → Compositor
Patrick, Michael did the region stuff I think, so I'm assigning this to you.
Sorry if you're not the right choice
nsIScriptableRegion is in the tree, and nsIDragService is now referencing it. Now
we just have to make nsRegionMac/Win/Gtk implement this interface.
what's up with this? what is the target milestone?
Status: NEW → ASSIGNED
Target Milestone: M11
Ah, you designed the interface, but didn't implement it.
you want me to do the work as well?
If you have the time. Otherwise, I could do the Mac/Windows and let Ramiro do
UNIX.
that would be preferred, if you can.
Blocks: 12659
putting on the beta tracking list
Assignee: beard → ramiro
Status: ASSIGNED → NEW
nsRegionMac.cpp can now handle a QueryInterface to nsIScriptableRegion, by
creating an instance of nsScriptableRegion, which delegates to an nsIRegion.
Handing the bug to Ramiro to take care of this on UNIX.
my question is this, i guess: how are these created? When JS is going to create
one, it will need to create a nsIScriptableRegion, not an nsIRegion (since there
is no idl for nsIRegion, it won't know about it). Is there a mechanism for doing
this?
Assignee: ramiro → pavlov
Reassigning to pavlov cause he likes bugs.
Whiteboard: [PDT+]
Putting on [PDT]+ radar.
Assignee: pavlov → beard
reassigning to beard since he has a fix
Status: NEW → ASSIGNED
nsIRegion won't be IDL-ified, but nsIScriptableRegion already is. I've created a
new CID for creation with a progID, and would like to check this in.
Assignee: beard → pavlov
Status: ASSIGNED → NEW
I've checked this in. Please make appropriate changes for your platforms.
Assignee: pavlov → kmcclusk
checked in fix on unix.  needs to be done on windows.
Status: NEW → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
checked in fix for Windows on Nov 2, 1999 5:38PM.

Closing out the bug, since it has been fixed on all three platforms.
Kevin, I'm not sure how to verify this fix.
This is a code-level change. You can mark it verified based on my comment.
Status: RESOLVED → VERIFIED
Based on Kevin's comments, marking as verified fixed.
No longer blocks: 11346
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.