1246518 - Capability parsing is incorrect (parameter vs final parameter confusion)

Status: RESOLVED FIXED

Description

[James Ross]

It seems there is some confusion over the CAP LS parsing:

[>>]       CAP LS
[<<]       :fripp.mozilla.org CAP James_ LS :multi-prefix sasl userhost-in-names
[INFO]     Available capabilities: multi-prefix sasl userhost-in-names
[EVAL-IN]  dumpObjectTree(e.server.caps)
[EVAL-OUT] + multi-prefix sasl userhost-in-names (object) null
           *

This is because the CZ code is expecting each capability to be another parameter, but in fact it is a list within a single (the final) parameter.

Comment 1

[James Ross]

Created attachment 8716806 [details] [diff] [review]
Split list of capabilities from parameter 3

Comment 2

[:Gijs]

Comment on attachment 8716806 [details] [diff] [review]
Split list of capabilities from parameter 3

Review of attachment 8716806 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/lib/irc.js
@@ +2001,5 @@
>           * null (if they don't exist) to indicate we don't know if they're
>           * enabled or not (but this will evaluate to false which matches that
>           * capabilities are only enabled on request).
>           */
> +        var caps = e.params[3].split(' ');

Nit: split(/\s+/) please so that we won't trip over multiple spaces / people using tabs / other wonky spacing characters.

Comment 3

[James Ross]

With nit fixed.

http://hg.mozilla.org/chatzilla/rev/d63b7cf65e93