Closed Bug 1246518 Opened 9 years ago Closed 9 years ago

Capability parsing is incorrect (parameter vs final parameter confusion)

Categories

(Other Applications Graveyard :: ChatZilla, defect)

defect
Not set
major

Tracking

(firefox47 affected)

RESOLVED FIXED
Tracking Status
firefox47 --- affected

People

(Reporter: bugzilla-mozilla-20000923, Assigned: bugzilla-mozilla-20000923)

References

()

Details

(Whiteboard: [cz-0.9.93])

Attachments

(1 file)

It seems there is some confusion over the CAP LS parsing: [>>] CAP LS [<<] :fripp.mozilla.org CAP James_ LS :multi-prefix sasl userhost-in-names [INFO] Available capabilities: multi-prefix sasl userhost-in-names [EVAL-IN] dumpObjectTree(e.server.caps) [EVAL-OUT] + multi-prefix sasl userhost-in-names (object) null * This is because the CZ code is expecting each capability to be another parameter, but in fact it is a list within a single (the final) parameter.
Assignee: rginda → bugzilla-mozilla-20000923
Status: NEW → ASSIGNED
Blocks: 687798
Attachment #8716806 - Flags: review?(gijskruitbosch+bugs)
Comment on attachment 8716806 [details] [diff] [review] Split list of capabilities from parameter 3 Review of attachment 8716806 [details] [diff] [review]: ----------------------------------------------------------------- ::: js/lib/irc.js @@ +2001,5 @@ > * null (if they don't exist) to indicate we don't know if they're > * enabled or not (but this will evaluate to false which matches that > * capabilities are only enabled on request). > */ > + var caps = e.params[3].split(' '); Nit: split(/\s+/) please so that we won't trip over multiple spaces / people using tabs / other wonky spacing characters.
Attachment #8716806 - Flags: review?(gijskruitbosch+bugs) → review+
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [cz-0.9.93]
Product: Other Applications → Other Applications Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: