Force windowless mode even if e10s is turned on

RESOLVED FIXED in Firefox 47

Status

()

RESOLVED FIXED
3 years ago
2 years ago

People

(Reporter: m_kato, Assigned: m_kato)

Tracking

(Depends on: 1 bug)

Trunk
mozilla47
Unspecified
Windows
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(e10s+, firefox47 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
Follow up bug 1201904.  When on e10s, windowless mode doesn't work well.  I should store sandbox level to nsPluginTag.
(Assignee)

Updated

3 years ago
Blocks: 1201904
(Assignee)

Comment 1

3 years ago
s/windowless mode doesn't work/force windowless mode doesn't work/
(Assignee)

Comment 2

3 years ago
Created attachment 8717315 [details]
MozReview Request: Bug 1246574 - Store sandbox level to nsPluginTag for e10s. r?jimm

When turned on e10s, plugin process creates from chrome process.  So content
process doesn't know current sandbox level.  To rewrite wmode attribute on
contnet process by sandbox level >= 2, we should store sandbox level to
nsPluginTag.

Review commit: https://reviewboard.mozilla.org/r/34127/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/34127/
Attachment #8717315 - Flags: review?(jmathies)
tracking-e10s: --- → +

Comment 3

3 years ago
I don't understand why you've moved this to nsPluginTag. Are you going to access this in future work?
(Assignee)

Comment 4

3 years ago
(In reply to Jim Mathies [:jimm] from comment #3)
> I don't understand why you've moved this to nsPluginTag. Are you going to
> access this in future work?

This idea is that I add sandbox level to nsPluginTag like AsyncInit flag to manage simply.  But should I add new function/method "int32_t GetSandboxLevel(nsPlugTag*)" instead?

Updated

3 years ago
Attachment #8717315 - Flags: review?(jmathies) → review+

Comment 5

3 years ago
Comment on attachment 8717315 [details]
MozReview Request: Bug 1246574 - Store sandbox level to nsPluginTag for e10s. r?jimm

https://reviewboard.mozilla.org/r/34127/#review31641

Comment 7

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/b71d96329d7a
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox47: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla47

Updated

2 years ago
Depends on: 1271398

Updated

2 years ago
Depends on: 1280328

Updated

2 years ago
Depends on: 1281583

Updated

2 years ago
Depends on: 1323403
Blocks: 1323750
You need to log in before you can comment on or make changes to this bug.