1246574 - Force windowless mode even if e10s is turned on

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[Makoto Kato [:m_kato]]

Follow up bug 1201904.  When on e10s, windowless mode doesn't work well.  I should store sandbox level to nsPluginTag.

Comment 1

[Makoto Kato [:m_kato]]

s/windowless mode doesn't work/force windowless mode doesn't work/

Comment 2

[Makoto Kato [:m_kato]]

Attachment: MozReview Request: Bug 1246574 - Store sandbox level to nsPluginTag for e10s. r?jimm

When turned on e10s, plugin process creates from chrome process.  So content
process doesn't know current sandbox level.  To rewrite wmode attribute on
contnet process by sandbox level >= 2, we should store sandbox level to
nsPluginTag.

Review commit: https://reviewboard.mozilla.org/r/34127/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/34127/

Comment 3

[Jim Mathies [:jimm]]

I don't understand why you've moved this to nsPluginTag. Are you going to access this in future work?

Comment 4

[Makoto Kato [:m_kato]]

(In reply to Jim Mathies [:jimm] from comment #3)
> I don't understand why you've moved this to nsPluginTag. Are you going to
> access this in future work?

This idea is that I add sandbox level to nsPluginTag like AsyncInit flag to manage simply.  But should I add new function/method "int32_t GetSandboxLevel(nsPlugTag*)" instead?

Comment 5

[Jim Mathies [:jimm]]

Comment on attachment 8717315 [details]
MozReview Request: Bug 1246574 - Store sandbox level to nsPluginTag for e10s. r?jimm

https://reviewboard.mozilla.org/r/34127/#review31641

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b71d96329d7a

Comment 7

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/b71d96329d7a