|Submitter||Diff||Changes||Open Issues||Last Updated|
|Error loading review requests:|
58 bytes, text/x-review-board-request
|Details | Review|
Follow up bug 1201904. When on e10s, windowless mode doesn't work well. I should store sandbox level to nsPluginTag.
s/windowless mode doesn't work/force windowless mode doesn't work/
Created attachment 8717315 [details] MozReview Request: Bug 1246574 - Store sandbox level to nsPluginTag for e10s. r?jimm When turned on e10s, plugin process creates from chrome process. So content process doesn't know current sandbox level. To rewrite wmode attribute on contnet process by sandbox level >= 2, we should store sandbox level to nsPluginTag. Review commit: https://reviewboard.mozilla.org/r/34127/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/34127/
Attachment #8717315 - Flags: review?(jmathies)
I don't understand why you've moved this to nsPluginTag. Are you going to access this in future work?
(In reply to Jim Mathies [:jimm] from comment #3) > I don't understand why you've moved this to nsPluginTag. Are you going to > access this in future work? This idea is that I add sandbox level to nsPluginTag like AsyncInit flag to manage simply. But should I add new function/method "int32_t GetSandboxLevel(nsPlugTag*)" instead?
Comment on attachment 8717315 [details] MozReview Request: Bug 1246574 - Store sandbox level to nsPluginTag for e10s. r?jimm https://reviewboard.mozilla.org/r/34127/#review31641
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox47: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in before you can comment on or make changes to this bug.