1246575 - Inline RegExp.prototype getters.

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect)

Description

[Tooru Fujisawa [:arai]]

Following RegExp.prototype getters just returns a value stored in slot.
  * RegExp.prototype.global
  * RegExp.prototype.ignoreCase
  * RegExp.prototype.multiline
  * RegExp.prototype.sticky
  * RegExp.prototype.unicode

Inlining then in IonBuilder::inlineNativeGetter should improve performance in bug 887016 and exec/test too.

Comment 1

[Tooru Fujisawa [:arai]]

octane/regexp score with WIP patch:
  before:  3848
  patched: 4019

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ac033a5db341

Comment 2

[Tooru Fujisawa [:arai]]

Attachment: Inline RegExp.prototype.{global,ignoreCase,multiline,sticky,unicode} getters.

When IonBuilder::inlineNativeGetter is called with RegExp.prototype getters (except source), it inlines it with MLoadFixedSlot with MIRType_Boolean.

Comment 3

[Hannes Verschore [:h4writer]]

Comment on attachment 8716938 [details] [diff] [review]
Inline RegExp.prototype.{global,ignoreCase,multiline,sticky,unicode} getters.

Review of attachment 8716938 [details] [diff] [review]:
-----------------------------------------------------------------

Cool! Great work.

::: js/src/vm/RegExpObject.cpp
@@ +123,5 @@
>      return createShared(cx, g);
>  }
>  
> +/* static */ bool
> +RegExpObject::isOriginalGetter(JSNative native, unsigned* slot)

Shouldn't we use "isOriginalFlagGetter" as name?

Comment 4

[Tooru Fujisawa [:arai]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b7f93e7b0caad9cc07b1c8d3e0bcbad59c0d35f3
Bug 1246575 - Inline RegExp.prototype.{global,ignoreCase,multiline,sticky,unicode} getters. r=h4writer

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b7f93e7b0caa