1246591 - Make browser/components/migration eslintable

Status: RESOLVED FIXED

(Firefox :: Migration, defect)

Comment 1

[:Gijs (he/him)]

Attachment: MozReview Request: Bug 1246591 - fix whitespace issues, r?MattN

Review commit: https://reviewboard.mozilla.org/r/33979/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/33979/

Comment 2

[:Gijs (he/him)]

Attachment: MozReview Request: Bug 1246591 - remove preprocessing and fix any other issues, r?MattN

Review commit: https://reviewboard.mozilla.org/r/33981/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/33981/

Comment 3

[:Gijs (he/him)]

Attachment: MozReview Request: Bug 1246591 - fix moz.build file and .eslintignore, r?MattN

Review commit: https://reviewboard.mozilla.org/r/33983/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/33983/

Comment 4

[Matthew N. [:MattN]]

Comment on attachment 8716908 [details]
MozReview Request: Bug 1246591 - fix whitespace issues, r?MattN

https://reviewboard.mozilla.org/r/33979/#review30721

Comment 5

[Matthew N. [:MattN]]

Comment on attachment 8716909 [details]
MozReview Request: Bug 1246591 - remove preprocessing and fix any other issues, r?MattN

https://reviewboard.mozilla.org/r/33981/#review30725

::: browser/components/migration/MigrationUtils.jsm:672
(Diff revision 1)
> -      try {
> -        this.migrators.next();
> -      }
> -      catch(ex) {
> +      // Note that we don't need to check the default browser first, because
> +      // if that one existed we would have used it in the block above this one.
> +      if (!gAvailableMigratorKeys.some(key => !!this.getMigrator(key))) {
> +        // None of the keys produced a usable migrator, so finish up here:

Nice catch on the simplification :)

Comment 6

[Matthew N. [:MattN]]

Comment on attachment 8716910 [details]
MozReview Request: Bug 1246591 - fix moz.build file and .eslintignore, r?MattN

https://reviewboard.mozilla.org/r/33983/#review30737

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/dfef1991cc00
https://hg.mozilla.org/integration/fx-team/rev/4ae0a01c95a3
https://hg.mozilla.org/integration/fx-team/rev/1aca4f261439

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/e417e32d9cb6

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/dfef1991cc00
https://hg.mozilla.org/mozilla-central/rev/4ae0a01c95a3
https://hg.mozilla.org/mozilla-central/rev/1aca4f261439
https://hg.mozilla.org/mozilla-central/rev/e417e32d9cb6