Closed Bug 1246632 Opened 4 years ago Closed 4 years ago

PushServiceHttp2 ackMsgRecv: A promise chain failed to handle a rejection

Categories

(Core :: DOM: Push Notifications, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla47
Tracking Status
firefox47 --- fixed

People

(Reporter: dragana, Assigned: dragana)

References

Details

Attachments

(1 file)

Patch from bug 1242755 only changed some timing during shutdown but it causes test_notification_http2.js  to fail:

 0:01.91 TEST_STATUS: Thread-1 test_complete FAIL [test_complete : 221] A promise chain failed to handle a rejection: Error: Error removing subscription: 2147500036 - rejection date: Mon Feb 08 2016 06:28:57 GMT-0800 (PST) - stack: PushServiceDelete.prototype.onStopRequest@resource://gre/modules/PushServiceHttp2.jsm:208:21

see comment: https://bugzilla.mozilla.org/show_bug.cgi?id=1242755#c10

it is because ackMsgRecv does not return promise.
Attachment #8716928 - Flags: review?(kcambridge)
Comment on attachment 8716928 [details] [diff] [review]
bug_PushAck.patch

Review of attachment 8716928 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM!
Attachment #8716928 - Flags: review?(kcambridge) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/3f31e2b533d3
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in before you can comment on or make changes to this bug.