If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Enable browser_clearplugindata.js in e10s

RESOLVED FIXED in Firefox 48

Status

()

Toolkit
Forget About Site
RESOLVED FIXED
2 years ago
a year ago

People

(Reporter: Neil Deakin, Assigned: Neil Deakin)

Tracking

(Blocks: 1 bug)

unspecified
mozilla48
Points:
---

Firefox Tracking Flags

(e10s+, firefox48 fixed, firefox49 fixed)

Details

(Whiteboard: [fce-active])

Attachments

(2 attachments)

(Assignee)

Description

2 years ago
Created attachment 8716983 [details] [diff] [review]
browser_clearplugindata

Updated

2 years ago
Blocks: 984139
tracking-e10s: ? → +
(Assignee)

Comment 1

2 years ago
Comment on attachment 8716983 [details] [diff] [review]
browser_clearplugindata

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d84120d7d9a4
Attachment #8716983 - Flags: review?(mak77)
Comment on attachment 8716983 [details] [diff] [review]
browser_clearplugindata

Review of attachment 8716983 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/forgetaboutsite/test/browser/browser_clearplugindata.js
@@ +36,5 @@
>      plugin.enabledState = oldEnabledState;
>    });
>  }
>  
> +add_task(function* () {

please name this "setup" so it's clearer should come first

@@ +63,3 @@
>  
> +  // Clear data for "foo.com" and its subdomains.
> +  yield ForgetAboutSite.removeDataFromDomain("foo.com");

Argh, I just looked at removeDataFromDomain and it's a nightmare, filed Bug 1247201.
Attachment #8716983 - Flags: review?(mak77) → review+
(Assignee)

Comment 3

2 years ago
https://treeherder.mozilla.org/#/jobs?repo=try&revision=fd4d9ca1f47a
(Assignee)

Comment 4

2 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/e4719dd204d128686f9063bcd8a9a44e82d83e65
Bug 1246667, enable browser_clearplugindata.js in e10s, r=mak

Comment 5

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/e4719dd204d1
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox48: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Neil - seems you fixed the test, but didn't enable it for E10S? The browser.ini still shows this as being disabled... http://mxr.mozilla.org/mozilla-central/source/toolkit/forgetaboutsite/test/browser/browser.ini#4

Is there further work needed beyond just enabling it?
Flags: needinfo?(enndeakin)
(Assignee)

Comment 7

a year ago
I think it can just be enabled.
Flags: needinfo?(enndeakin)
https://treeherder.mozilla.org/#/jobs?repo=try&revision=504ae85bd14a
Neil: I see a lot of intermittent failures of this test in my try push to enable it on E10S (comment 8). Linux seems worst off (4/4 failures on Linux x64 opt), and even 1 instance on Windows 8 x64 opt. I just did a few more retriggers, as it's not the same test chunk on all platforms.

Can you investigate this?
Status: RESOLVED → REOPENED
Flags: needinfo?(enndeakin)
Resolution: FIXED → ---
(Assignee)

Comment 10

a year ago
Created attachment 8753437 [details] [diff] [review]
Possible fix
Flags: needinfo?(enndeakin)
Whiteboard: [fct-active]
Whiteboard: [fct-active] → [fce-active]
(Assignee)

Comment 11

a year ago
Comment on attachment 8753437 [details] [diff] [review]
Possible fix

Review of attachment 8753437 [details] [diff] [review]:
-----------------------------------------------------------------

This patch just makes the initialization happen outside of the load event
Attachment #8753437 - Flags: review?(mak77)
Comment on attachment 8753437 [details] [diff] [review]
Possible fix

Review of attachment 8753437 [details] [diff] [review]:
-----------------------------------------------------------------

This likely wants a Try run with some retriggers before landing.

::: toolkit/forgetaboutsite/test/browser/browser_clearplugindata.js
@@ +55,5 @@
>    setTestPluginEnabledState(Ci.nsIPluginTag.STATE_ENABLED, pluginTag);
>  });
>  
>  add_task(function* () {
>    // Load page to set data for the plugin.

I'd probably move this comment after the openNewForegroundTab call and change it to

// Set data for the plugin after the page load.
Attachment #8753437 - Flags: review?(mak77) → review+
(Assignee)

Comment 13

a year ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/cbb4a840f81ed3e560d6395f61ad15f3a7c01e7e
Bug 1246667, properly enable browser_clearplugindata.js in e10s, r=mak

Comment 14

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/cbb4a840f81e
Status: REOPENED → RESOLVED
Last Resolved: 2 years agoa year ago
status-firefox49: --- → fixed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.