Closed Bug 1246707 Opened 4 years ago Closed 4 years ago

Increase duration of time snackbar is shown

Categories

(Firefox for Android :: General, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 47
Tracking Status
firefox45 --- fixed
firefox46 --- verified
firefox47 --- verified
relnote-firefox --- 47+
fennec 45+ ---

People

(Reporter: Margaret, Assigned: sebastian, Mentored)

References

()

Details

(Whiteboard: [lang=java])

Attachments

(2 files)

We're hearing complaints that the snackbar disappears more quickly than our old button toasts used to.

We should try increasing the duration of time these snackbars are shown.

Looking briefly at the code, it seems like we'll have to do this on an ad-hoc basis, but we should try replacing some of these LENGTH_SHORT parameters with LENGTH_LONG.

http://mxr.mozilla.org/mozilla-central/ident?i=showSnackbar
Our initial guideline was to use SHORT for snackbars without action and LONG for snackbars with an action button. In addition to the already defined constants we can use an arbitrary duration too. Maybe we should create our own constants to keep things consistent.

Currently we use the values of the support library:

SHORT: 1500ms
LONG: 2750ms

I guess with bug 1233467 landed greater values are not that annoying anymore.

(In reply to :Margaret Leibovic from comment #0)
> http://mxr.mozilla.org/mozilla-central/ident?i=showSnackbar

Additionally we need to update the snackbars shown from JS:
http://mxr.mozilla.org/mozilla-central/search?string=Snackbars.show
Flags: needinfo?(alam)
As long as they disappear as soon as a user interacts outside of them, we can be less conservative here and use LONG for all of our duration values. 

I don't expect too much bad feedback from this change. Inbox has snackbars that seem to persist longer than 2750ms. But they do dismiss when a user interacts elsewhere on the screen.
Flags: needinfo?(alam)
Should we try to land a fix and uplift it to 45, where we're shipping these snackbars? At the very least we could uplift this to 46.
Flags: needinfo?(bbermes)
+1 in trying to uplift and go with the LONG one as long as they disappear as mentioned my Anthony.
Flags: needinfo?(bbermes)
Margaret, can we get an assignee here?
Flags: needinfo?(margaret.leibovic)
I can do it.
Assignee: nobody → s.kaspari
Status: NEW → ASSIGNED
Flags: needinfo?(margaret.leibovic)
It might be late to get this into beta, but we can try.
tracking-fennec: --- → 45+
Comment on attachment 8720320 [details]
MozReview Request: Bug 1246707 - Set all Snackbar durations to LONG. r?ahunt

https://reviewboard.mozilla.org/r/35265/#review32137

Works nicely, appears to cover all our snackbars!
Attachment #8720320 - Flags: review?(ahunt) → review+
https://hg.mozilla.org/mozilla-central/rev/b8449a2d5fc1
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 47
Release Note Request (optional, but appreciated)
[Why is this notable]:
[Suggested wording]: Extend time to show snackbar
[Links (documentation, blog post, etc)]:
relnote-firefox: --- → ?
Comment on attachment 8720320 [details]
MozReview Request: Bug 1246707 - Set all Snackbar durations to LONG. r?ahunt

Approval Request Comment
[Feature/regressing bug #]: Snackbars have been introduced app-wide in Firefox 45. See bug 1157526 and follow-ups.
[User impact if declined]: Some users complained that some snackbars disappear too quickly.
[Describe test coverage new/current, TreeHerder]: Local testing.
[Risks and why]: Very low risk, the patch is replacing SHORT constants with LONG.
[String/UUID change made/needed]: -
Attachment #8720320 - Flags: approval-mozilla-beta?
Attachment #8720320 - Flags: approval-mozilla-aurora?
Comment on attachment 8720320 [details]
MozReview Request: Bug 1246707 - Set all Snackbar durations to LONG. r?ahunt

Let's take this in aurora in response to user feedback.
Attachment #8720320 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment on attachment 8720320 [details]
MozReview Request: Bug 1246707 - Set all Snackbar durations to LONG. r?ahunt

Polish a new feature with a trivial change, taking it.
Attachment #8720320 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
has problems during uplift to beta:

merging mobile/android/chrome/content/browser.js
warning: conflicts while merging mobile/android/chrome/content/ActionBarHandler.js! (edit, then use 'hg resolve --mark')
warning: conflicts while merging mobile/android/chrome/content/MasterPassword.js! (edit, then use 'hg resolve --mark')
warning: conflicts while merging mobile/android/chrome/content/Reader.js! (edit, then use 'hg resolve --mark')
warning: conflicts while merging mobile/android/chrome/content/SelectionHandler.js! (edit, then use 'hg resolve --mark')
warning: conflicts while merging mobile/android/chrome/content/aboutLogins.js! (edit, then use 'hg resolve --mark')
Flags: needinfo?(s.kaspari)
This is the patch updated for BETA.
Flags: needinfo?(s.kaspari) → needinfo?(cbook)
It was already in the release notes.
relnote-firefox: ? → ---
The duration of time snackbars are shown is increased, so:
Verified as fixed using:
Device: One A2001 (Android 5.1.1) 
Build: Firefox for Android 47.0a1 (2015-03-01)
Verified as fixed on Firefox 46 Beta 1
(In reply to Ritu Kothari (:ritu) from comment #24)
> Added to Fx 47 (Aurora) release notes
Not sure why ?
This landed in 45 and it is not a big deal. The actual feature is bug 1157526 (and part of the release notes)
Flags: needinfo?(rkothari)
(In reply to Sylvestre Ledru [:sylvestre] from comment #26)
> (In reply to Ritu Kothari (:ritu) from comment #24)
> > Added to Fx 47 (Aurora) release notes
> Not sure why ?
> This landed in 45 and it is not a big deal. The actual feature is bug
> 1157526 (and part of the release notes)

Oops my bad. This had relnote:? flag set and therefore turned up on my list and I only looked at target milestone 47 without realizing this was uplifted to 45 and 46. I've removed it from 47 relnotes.
Flags: needinfo?(rkothari)
QA Contact: teodora.vermesan
You need to log in before you can comment on or make changes to this bug.