1246707 - Increase duration of time snackbar is shown

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[:Margaret Leibovic]

We're hearing complaints that the snackbar disappears more quickly than our old button toasts used to.

We should try increasing the duration of time these snackbars are shown.

Looking briefly at the code, it seems like we'll have to do this on an ad-hoc basis, but we should try replacing some of these LENGTH_SHORT parameters with LENGTH_LONG.

http://mxr.mozilla.org/mozilla-central/ident?i=showSnackbar

Comment 1

[Sebastian Kaspari (:sebastian; :pocmo)]

Our initial guideline was to use SHORT for snackbars without action and LONG for snackbars with an action button. In addition to the already defined constants we can use an arbitrary duration too. Maybe we should create our own constants to keep things consistent.

Currently we use the values of the support library:

SHORT: 1500ms
LONG: 2750ms

I guess with bug 1233467 landed greater values are not that annoying anymore.

(In reply to :Margaret Leibovic from comment #0)
> http://mxr.mozilla.org/mozilla-central/ident?i=showSnackbar

Additionally we need to update the snackbars shown from JS:
http://mxr.mozilla.org/mozilla-central/search?string=Snackbars.show

Comment 2

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

As long as they disappear as soon as a user interacts outside of them, we can be less conservative here and use LONG for all of our duration values. 

I don't expect too much bad feedback from this change. Inbox has snackbars that seem to persist longer than 2750ms. But they do dismiss when a user interacts elsewhere on the screen.

Comment 3

[:Margaret Leibovic]

Should we try to land a fix and uplift it to 45, where we're shipping these snackbars? At the very least we could uplift this to 46.

Comment 4

[Barbara Bermes [:barbara] - NI please!]

+1 in trying to uplift and go with the LONG one as long as they disappear as mentioned my Anthony.

Comment 5

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Margaret, can we get an assignee here?

Comment 6

[Sebastian Kaspari (:sebastian; :pocmo)]

I can do it.

Comment 7

[:Margaret Leibovic]

It might be late to get this into beta, but we can try.

Comment 8

[Sebastian Kaspari (:sebastian; :pocmo)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=095f92345465

Comment 9

[Sebastian Kaspari (:sebastian; :pocmo)]

Attachment: MozReview Request: Bug 1246707 - Set all Snackbar durations to LONG. r?ahunt

Review commit: https://reviewboard.mozilla.org/r/35265/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/35265/

Comment 10

[Andrzej Hunt :ahunt]

Comment on attachment 8720320 [details]
MozReview Request: Bug 1246707 - Set all Snackbar durations to LONG. r?ahunt

https://reviewboard.mozilla.org/r/35265/#review32137

Works nicely, appears to cover all our snackbars!

Comment 11

[Sebastian Kaspari (:sebastian; :pocmo)]

https://hg.mozilla.org/integration/fx-team/rev/b8449a2d5fc1817544c3c2d3a38085823af48d2e
Bug 1246707 - Set all Snackbar durations to LONG. r=ahunt

Comment 12

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/b8449a2d5fc1

Comment 13

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Release Note Request (optional, but appreciated)
[Why is this notable]:
[Suggested wording]: Extend time to show snackbar
[Links (documentation, blog post, etc)]:

Comment 14

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8720320 [details]
MozReview Request: Bug 1246707 - Set all Snackbar durations to LONG. r?ahunt

Approval Request Comment
[Feature/regressing bug #]: Snackbars have been introduced app-wide in Firefox 45. See bug 1157526 and follow-ups.
[User impact if declined]: Some users complained that some snackbars disappear too quickly.
[Describe test coverage new/current, TreeHerder]: Local testing.
[Risks and why]: Very low risk, the patch is replacing SHORT constants with LONG.
[String/UUID change made/needed]: -

Comment 15

[Liz Henry (:lizzard) (relman/hg->git project)]

Marking affected for 45+

Comment 16

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8720320 [details]
MozReview Request: Bug 1246707 - Set all Snackbar durations to LONG. r?ahunt

Let's take this in aurora in response to user feedback.

Comment 17

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/6852f8afb9ea

Comment 18

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8720320 [details]
MozReview Request: Bug 1246707 - Set all Snackbar durations to LONG. r?ahunt

Polish a new feature with a trivial change, taking it.

Comment 19

[Carsten Book [:Tomcat]]

has problems during uplift to beta:

merging mobile/android/chrome/content/browser.js
warning: conflicts while merging mobile/android/chrome/content/ActionBarHandler.js! (edit, then use 'hg resolve --mark')
warning: conflicts while merging mobile/android/chrome/content/MasterPassword.js! (edit, then use 'hg resolve --mark')
warning: conflicts while merging mobile/android/chrome/content/Reader.js! (edit, then use 'hg resolve --mark')
warning: conflicts while merging mobile/android/chrome/content/SelectionHandler.js! (edit, then use 'hg resolve --mark')
warning: conflicts while merging mobile/android/chrome/content/aboutLogins.js! (edit, then use 'hg resolve --mark')

Comment 20

[Sebastian Kaspari (:sebastian; :pocmo)]

Attachment: BETA-1246707_snackbar_LONG.patch

This is the patch updated for BETA.

Comment 21

[Carsten Book [:Tomcat]]

 https://hg.mozilla.org/releases/mozilla-beta/rev/7a801bcc77e9
https://hg.mozilla.org/releases/mozilla-release/rev/212dd4b03122

Comment 22

[Sylvestre Ledru [:Sylvestre]]

It was already in the release notes.

Comment 23

[Teodora Vermesan (:TeoVermesan)]

The duration of time snackbars are shown is increased, so:
Verified as fixed using:
Device: One A2001 (Android 5.1.1) 
Build: Firefox for Android 47.0a1 (2015-03-01)

Comment 24

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Added to Fx 47 (Aurora) release notes

Comment 25

[u421692]

Verified as fixed on Firefox 46 Beta 1

Comment 26

[Sylvestre Ledru [:Sylvestre]]

(In reply to Ritu Kothari (:ritu) from comment #24)
> Added to Fx 47 (Aurora) release notes
Not sure why ?
This landed in 45 and it is not a big deal. The actual feature is bug 1157526 (and part of the release notes)

Comment 27

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

(In reply to Sylvestre Ledru [:sylvestre] from comment #26)
> (In reply to Ritu Kothari (:ritu) from comment #24)
> > Added to Fx 47 (Aurora) release notes
> Not sure why ?
> This landed in 45 and it is not a big deal. The actual feature is bug
> 1157526 (and part of the release notes)

Oops my bad. This had relnote:? flag set and therefore turned up on my list and I only looked at target milestone 47 without realizing this was uplifted to 45 and 46. I've removed it from 47 relnotes.