1246719 - mach mochitest --valgrind: use comma as separator for --valgrind-args

Status: RESOLVED FIXED

(Testing :: Mochitest, defect)

Description

[Julian Seward [:jseward]]

Bug 1185244 adds support for a --valgrind flag to |mach mochitest|,
which makes it possible to run Mochitests on Valgrind.  The
--valgrind-args argument facilitates passing extra flags to the
Valgrind run.  Unfortunately this does not work well when it is
necessary to pass more than one additional flag to Valgrind, since the
spaces in between the flags get misinterpreted, and making it work
requires confusing and undocumented multi-level shell quoting.

It would be more robust and less confusing to separate the flags with
commas, and document that.  For example

  --valgrind-args=--foo=bar,-v,--xyzzy=no

rather than having to guess which, if any, of these will actually work:

  --valgrind-args="--foo=bar -v --xyzzy=no"
  --valgrind-args="'--foo=bar -v --xyzzy=no'"
  --valgrind-args='"--foo=bar -v --xyzzy=no"'

Comment 1

[Julian Seward [:jseward]]

Attachment: mach_valgrind_args_comma.diff

Comment 2

[James Graham [:jgraham]]

Comment on attachment 8717064 [details] [diff] [review]
mach_valgrind_args_comma.diff

Review of attachment 8717064 [details] [diff] [review]:
-----------------------------------------------------------------

Sure, I guess. Usability doesn't seem great, but I don't have a better suggestion right now.

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2a70aa2e1d13

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/2a70aa2e1d13