Closed Bug 1246719 Opened 4 years ago Closed 4 years ago

mach mochitest --valgrind: use comma as separator for --valgrind-args

Categories

(Testing :: Mochitest, defect)

defect
Not set

Tracking

(firefox47 fixed)

RESOLVED FIXED
mozilla47
Tracking Status
firefox47 --- fixed

People

(Reporter: jseward, Assigned: jseward)

Details

Attachments

(1 file)

Bug 1185244 adds support for a --valgrind flag to |mach mochitest|,
which makes it possible to run Mochitests on Valgrind.  The
--valgrind-args argument facilitates passing extra flags to the
Valgrind run.  Unfortunately this does not work well when it is
necessary to pass more than one additional flag to Valgrind, since the
spaces in between the flags get misinterpreted, and making it work
requires confusing and undocumented multi-level shell quoting.

It would be more robust and less confusing to separate the flags with
commas, and document that.  For example

  --valgrind-args=--foo=bar,-v,--xyzzy=no

rather than having to guess which, if any, of these will actually work:

  --valgrind-args="--foo=bar -v --xyzzy=no"
  --valgrind-args="'--foo=bar -v --xyzzy=no'"
  --valgrind-args='"--foo=bar -v --xyzzy=no"'
Attachment #8717064 - Flags: review?(james)
Comment on attachment 8717064 [details] [diff] [review]
mach_valgrind_args_comma.diff

Review of attachment 8717064 [details] [diff] [review]:
-----------------------------------------------------------------

Sure, I guess. Usability doesn't seem great, but I don't have a better suggestion right now.
Attachment #8717064 - Flags: review?(james) → review+
https://hg.mozilla.org/mozilla-central/rev/2a70aa2e1d13
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in before you can comment on or make changes to this bug.