1246774 - Initial alerts UI has problems

Status: RESOLVED FIXED

(Tree Management :: Perfherder, defect)

Description

[William Lachance (:wlach)]

I think we've determined that the initial alerts management UI had problems that prevented it from being a viable replacement to alertmanager. Specifically, it's filtering abilities were quite lacking, and the current design of the API makes that difficult to fix.

I've been working on a rewrite to address this and other issues. I'm not sure if it's worth discussing that in detail here, I'd rather spend that effort on writing a blog post describing what I did after the fact. Creating this bug just to track the work.

Comment 1

[GitHub Autolander Bot]

Attachment: [treeherder] wlach:1246774 > mozilla:master

Comment 2

[William Lachance (:wlach)]

Comment on attachment 8717159 [details] [review]
[treeherder] wlach:1246774 > mozilla:master

Hey Joel, so this is almost ready to land, I think. I know you're busy this week, I'm more asking for a rubber-stamp than a proper review. I think we agreed that the user interface model would work well for the most common use cases we have.

I'm breaking with existing treeherder/perfherder best practice by just creating a monster patch which changes a lot of disparate things in one commit, but it doesn't seem worth the time to disentangle when we're essentially an "extreme alpha" product.

I know for a fact that this has bugs and missing features, but it's worlds better than the old user interface and I think we can just fix things as they come in the weeks ahead. I'd rather just get something in that we can use and experiment with. I'm fairly confident that I at least got the data model right this time.

Note that applying this will involve nuking the existing set of alerts and generating new ones, so it shouldn't just be deployed to stage without database work beforehand. I can take care of that.

Comment 3

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/8708550d9d52e80dfde1312ff2fe6136fe7144be
Bug 1246774 - Redesign performance alerts management UI

The initial prototype had problems, especially in how we filtered
alerts. Hopefully this one will work a bit better. :)

Comment 4

[GitHub Autolander Bot]

Attachment: [treeherder] wlach:1246774-2 > mozilla:master

Comment 5

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/546d3ef47a71180f3e72e1517bea7821ae1beaaf
Bug 1246774 - Refactor perf migrations so stuff doesn't break on upgrade

Delete everything via a manually generated migration, then recreate