Expose Console to the WorkerDebuggerGlobalScope

RESOLVED FIXED in Firefox 47

Status

RESOLVED FIXED
3 years ago
3 months ago

People

(Reporter: bgrins, Assigned: baku)

Tracking

unspecified
Firefox 47
Dependency tree / graph

Firefox Tracking Flags

(firefox47 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

3 years ago
I really want to be able to console.log within actors in the worker thread.

Also, I believe we might need access to this to be able to access console events in Bug 1246091.
(Reporter)

Comment 1

3 years ago
Andrea, you mentioned this might not be too hard to do.  I haven't been able to figure it out - can you help?
Flags: needinfo?(amarchesini)
(Assignee)

Comment 2

3 years ago
(In reply to Brian Grinstead [:bgrins] from comment #1)
> Andrea, you mentioned this might not be too hard to do.  I haven't been able
> to figure it out - can you help?

Everything depends on if you want to see your console events mixed with the content console events or you want to have a separate console object. I guess you want a separate console object... I'm going to propose a patch soon.
Flags: needinfo?(amarchesini)
(Assignee)

Comment 3

3 years ago
Created attachment 8717326 [details] [diff] [review]
console4.patch
Assignee: nobody → amarchesini
Attachment #8717326 - Flags: review?(khuey)
(Assignee)

Comment 4

3 years ago
Created attachment 8717330 [details] [diff] [review]
console4.patch

With a mochitest.
Attachment #8717326 - Attachment is obsolete: true
Attachment #8717326 - Flags: review?(khuey)
Attachment #8717330 - Flags: review?(khuey)
(Reporter)

Comment 5

3 years ago
(In reply to Andrea Marchesini (:baku) from comment #2)
> (In reply to Brian Grinstead [:bgrins] from comment #1)
> > Andrea, you mentioned this might not be too hard to do.  I haven't been able
> > to figure it out - can you help?
> 
> Everything depends on if you want to see your console events mixed with the
> content console events or you want to have a separate console object.

Separate, I think
Comment on attachment 8717330 [details] [diff] [review]
console4.patch

Review of attachment 8717330 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/webidl/Console.webidl
@@ +4,5 @@
>   * License, v. 2.0. If a copy of the MPL was not distributed with this
>   * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
>  
>  [ChromeOnly,
> + Exposed=(Window,Worker, WorkerDebugger)]

either put a space between Window and Worker, or remove it between Worker and WorkerDebugger.  Whatever other IDLs do, ideally.
Attachment #8717330 - Flags: review?(khuey) → review+

Comment 9

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/e42032ce8d5a
https://hg.mozilla.org/mozilla-central/rev/d8b60725f683
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox47: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 47
(Reporter)

Updated

3 years ago
Blocks: 1249709

Updated

3 months ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.