1246844 - [mozdevice] do not requires root for operations required by mozregression

Status: RESOLVED DUPLICATE of bug 1245347

(Testing :: Mozbase, defect)

Description

[Julien Pagès (:parkouss)]

See discussion in bug 1245347 - it would be great to not require root when using adb_android.py in mozregression.

I don't know where the root access occur. Here is the complete list of adb calls made by mozregression:

ADBHost().devices()
ADBAndroid.install_app
ADBAndroid.uninstall_app
ADBAndroid.exists, ADBAndroid.rm, ADBAndroid.push # to push a profile
ADBAndroid.launch_fennec

mozregression source: https://github.com/mozilla/mozregression/blob/master/mozregression/launchers.py

Comment 1

[Bob Clary [:bc] (inactive)]

Attachment: grep adb launchers.py

Comment 2

[Bob Clary [:bc] (inactive)]

Comment on attachment 8810934 [details]
grep adb launchers.py

>$ grep adb launchers.py
>    adb = None
>        except ADBError as adb_error:
>            raise LauncherNotRunnable(str(adb_error))
>        self.adb = ADBAndroid()
>            self.adb.uninstall_app(self.package_name)
def uninstall_app(self, app_name, reboot=False, timeout=None):
no explicit use of root

>        self.adb.install_app(dest)
def install_app(self, apk_path, timeout=None):
no explicit use of root

>        self.remote_profile = "/".join([self.adb.test_root,
>        if self.adb.exists(self.remote_profile):
>            self.adb.rm(self.remote_profile, recursive=True)
>        self.adb.push(profile.profile, self.remote_profile)

No explicit use of root. Appear to work fine in mozregression with patches from bug 1245347
Note the test root will usually be a subdirectory of /storage/sdcard* or /sdcard where ownership and permissions are fixed. If the test root is set to /data/local/tests root may be required.

>        self.adb.launch_fennec(self.package_name,
no root required.

>        while self.adb.process_exist(self.package_name):
no root required.

>        self.adb.stop_application(self.package_name)
does not require root for android >= 3.0

>        if self.adb.exists(self.remote_profile):
>            self.adb.rm(self.remote_profile, recursive=True)
again no issue for paths on external storage.

Comment 3

[Bob Clary [:bc] (inactive)]

duping to bug 1245347 which will resolve this.