1246921 - Regression: Unable to edit logins

Status: VERIFIED FIXED

(Firefox for iOS :: General, defect)

Description

[Catalin Suciu [:csuciu]]

1. Save a login
2. Go to Settings -> Logins
3. Tap on the saved login
4. Tap on Edit
5. Modify the username and the password 
6. Tap on 'Done'

Result: The changes are not saved

This was working on build 2.0(4)

Comment 1

[Stephan Leroux [:sleroux]]

Just to clarify, did you by chance enter a blank password?

Comment 2

[Catalin Suciu [:csuciu]]

No, I've just added a few characters to the saved one

Comment 3

[Aaron Train [:aaronmt]]

Reproducible on master (2.0) as well with newly created logins.

Comment 4

[Stephan Leroux [:sleroux]]

Attachment: Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/1515

Also adds some fixes to the tests to get them working again after some merges in master. Added both of you so whoever gets to it first :)

Comment 5

[Brian Nicholson (:bnicholson)]

Comment on attachment 8717614 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/1515

LGTM!

Comment 6

[Richard Newman [:rnewman]]

Comment on attachment 8717614 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/1515

One comment on the diff.

Comment 7

[Stephan Leroux [:sleroux]]

master 3dad82a8d6ea2454d4cea01cf8752176d2bec4c7

Comment 8

[Catalin Suciu [:csuciu]]

Verified as fixed on build 2.0(2006)

Comment 9

[Catalin Suciu [:csuciu]]

Apparently I've rushed into 'Verifying' this bug because the edited passwords are still not saved.
I've logged a new bug for this: https://bugzilla.mozilla.org/show_bug.cgi?id=1247884