1246925 - [Static Analysis][Explicit null dereferenced] In function RefPtr<NrIceCtx> NrIceCtx::Create

Status: RESOLVED FIXED

(Core :: WebRTC: Networking, defect)

Description

[Andi [:andi]]

The Static Analysis tool Coverity added that pointers filtering_type and mapping_type might be explicitly null dereferenced:

>>    MOZ_MTLOG(ML_DEBUG, "NAT filtering type: " << filtering_type);
>>    MOZ_MTLOG(ML_DEBUG, "NAT mapping type: " << mapping_type);

Judging by the looks of the code these pointers are null tested in:

>>  if (mapping_type && filtering_type) {
>>    TestNat* test_nat = new TestNat;
>>    test_nat->filtering_type_ = TestNat::ToNatBehavior(filtering_type);
>>    test_nat->mapping_type_ = TestNat::ToNatBehavior(mapping_type);
>>    test_nat->block_udp_ = block_udp;

I case filtering_type and mapping_type are null a null pointer dereference will occur only log level for this component is set to Verbose but still i think we should move the logging code inside the if statement.

Comment 1

[Andi [:andi]]

Attachment: MozReview Request: Bug 1246925 - log filtering_type and mapping_type only if they are valid pointers. r?ekr

Review commit: https://reviewboard.mozilla.org/r/34175/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/34175/

Comment 2

[Eric Rescorla (:ekr)]

Comment on attachment 8717419 [details]
MozReview Request: Bug 1246925 - log filtering_type and mapping_type only if they are valid pointers. r?ekr

https://reviewboard.mozilla.org/r/34175/#review30855

Comment 3

[Andi [:andi]]

since autoland is down setting it to checking-needed

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/557693d740ec

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/557693d740ec