Closed Bug 1246951 Opened 9 years ago Closed 9 years ago

[UX] Pixel snap rotation icon

Categories

(DevTools :: Responsive Design Mode, defect, P1)

Product:
DevTools
Component:
Responsive Design Mode
Type:
defect

Tracking

(firefox47 affected, firefox48 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 48
Iteration:
48.3 - Apr 25
Tracking Flags:
Tracking Status
firefox47 --- affected
firefox48 --- fixed

People

(Reporter: jryans, Assigned: hholmes)

References

Details

(Whiteboard: [multiviewport] [ux])

Attachments

(1 file)

pixelsnap.patch
6.18 KB, patch
gl
: review+
Details | Diff | Splinter Review
The rotation icon we're going to land in bug 1239441 looks fuzzy on 1x displays. Try tweaking the icon to improve.
Flags: qe-verify-
Summary: Pixel snap rotation icon → [UX] Pixel snap rotation icon
Assignee: nobody → hholmes
A few notes from IRC after talking with Tim: - The icon looks fine on Windows because we're using a mask-image. We need to check it on other platforms, though. (Notably, 1x Mac screens, Linux) - A hack to get icons to be hardware accelerated (and thus, crisper) is to use transform="translate(0)". Worth remembering for the future.
Status: NEW → ASSIGNED
Iteration: --- → 48.1 - Mar 21
Priority: P3 → P1
Whiteboard: [multiviewport][ux] → [multiviewport] [ux]
Iteration: 48.1 - Mar 21 → 48.2 - Apr 4
Iteration: 48.2 - Apr 4 → 48.3 - Apr 18
Attached patch pixelsnap.patch — — Splinter Review
Ended up fiddling with all three icons you can currently see—rotate, screenshot, and close.
Attachment #8738580 - Flags: review?(gl)
Attachment #8738580 - Flags: review?(gl) → review+
https://hg.mozilla.org/mozilla-central/rev/b1fe64219ad8
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox48: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: