1247041 - This video SIGSEGVs firefox

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P1)

Description

[Simonas Kazlauskas [:nagisa/:simukis]]

Attachment: SIGSEGV payload

Playing the attached video will reliably SIGSEGV firefox, it looks like somewhere inside ffmpeg. ffplay and mpv (uses ffmpeg) do not suffer from this. I’ll add the backtrace and stdout in next comment (*goes to sigsegv the browser more*).

Comment 1

[Simonas Kazlauskas [:nagisa/:simukis]]

The output:

[h264 @ 0x7f37a9daa800] get_format() cannot be called after ff_thread_finish_setup()
[h264 @ 0x7f37a9daa800] get_format() cannot be called after ff_thread_finish_setup()
[h264 @ 0x7f37a9daa800] decode_slice_header error
Assertion !h->setup_finished failed at libavcodec/h264_slice.c:1168
Redirecting call to abort() to mozalloc_abort

fish: “firefox” terminated by signal SIGSEGV (Address boundary error)

The stacktrace is uninteresting (no debug symbols)

Comment 2

[Jean-Yves Avenard [:jya]]

Which version of libavcodec do you have installed?

Comment 3

[Simonas Kazlauskas [:nagisa/:simukis]]

$ pacman -Qs libavcodec
local/ffmpeg 1:2.8.6-2
    Complete solution to record, convert and stream audio and video

Comment 4

[Simonas Kazlauskas [:nagisa/:simukis]]

(Oh, I realize I cleared out the needinfo which wasn’t for me, but since you needinfo-d yourself, I assume you meant to needinfo me.

Comment 5

[Simonas Kazlauskas [:nagisa/:simukis]]

ffmpeg --version reports this: 

libavcodec     56. 60.100 / 56. 60.100

Comment 6

[Jean-Yves Avenard [:jya]]

No, I ni? myself so I don't forget :)

Comment 7

[Jean-Yves Avenard [:jya]]

Attachment: MozReview Request: Bug 1247041: [ffmpeg] Request YUVJ420P format explicitly. r?kentuckyfriedtakahe

Requesting YUV420P causes crashes with some version of FFmpeg.

Review commit: https://reviewboard.mozilla.org/r/34293/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/34293/

Comment 8

[Jean-Yves Avenard [:jya]]

[Tracking Requested - why for this release]: In bug 1233340 we added support for some YUVJ420P (12bppp YUV420) however this causes crashing with some version of FFmpeg.

Comment 9

[Jean-Yves Avenard [:jya]]

Anthony, I tested with LibAV 0.8 up to FFmpeg master ; on both linux and mac. this new method works fine with bug 1233340 and this video.

Interestingly, I had copied the PixelFormat method of LibAV, and assigning PIX_FMT_YUV420P is what they do when it's YUVJ420P

Comment 10

[Evangelos Foutras]

Firefox 44 is affected too.

Comment 11

[Jean-Yves Avenard [:jya]]

Comment on attachment 8717752 [details]
MozReview Request: Bug 1247041: [ffmpeg] Request YUVJ420P format explicitly. r?kentuckyfriedtakahe

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/34293/diff/1-2/

Comment 12

[Jean-Yves Avenard [:jya]]

sorry, I was playing with mozreview..

Comment 13

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

Comment on attachment 8717752 [details]
MozReview Request: Bug 1247041: [ffmpeg] Request YUVJ420P format explicitly. r?kentuckyfriedtakahe

https://reviewboard.mozilla.org/r/34293/#review31523

Comment 14

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9833fd16adb8

Comment 15

[Sylvestre Ledru [:Sylvestre]]

Tracking to make sure we uplift it in 45.

Comment 16

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/9833fd16adb8

Comment 17

[Jean-Yves Avenard [:jya]]

Comment on attachment 8717752 [details]
MozReview Request: Bug 1247041: [ffmpeg] Request YUVJ420P format explicitly. r?kentuckyfriedtakahe

Approval Request Comment
[Feature/regressing bug #]:1247041
[User impact if declined]: Crashes
[Describe test coverage new/current, TreeHerder]: In central, manual test.
[Risks and why]: Low, the patch is simple and it was verified against all versions of LibAV and FFmpeg
[String/UUID change made/needed]: none

Patch will not port to beta it requires a small modification.
Will provide it soon

Comment 18

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8717752 [details]
MozReview Request: Bug 1247041: [ffmpeg] Request YUVJ420P format explicitly. r?kentuckyfriedtakahe

Fixes a video playback issue (crash), seems like a simple fix. Let's uplift to Aurora46.

Comment 19

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/475bffdf1921

Comment 20

[Sylvestre Ledru [:Sylvestre]]

This missed beta 7. Do you have an eta for the beta-rebased patch? Thanks

Comment 21

[Jean-Yves Avenard [:jya]]

(In reply to Sylvestre Ledru [:sylvestre] from comment #20)
> This missed beta 7. Do you have an eta for the beta-rebased patch? Thanks

Oh... miscommunication here, as the beta uplift hadn't been approved, I didn't look into it (it will take me two minutes to make the change)

Comment 22

[Jean-Yves Avenard [:jya]]

Attachment: [ffmpeg] Request YUVJ420P format explicitly. r=kentuckyfriedtakahe, a=sylvestre

Patch for beta

Comment 23

[Jean-Yves Avenard [:jya]]

Sylvestre. Now that the patch for beta is available, will you allow this on?

Comment 24

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8721101 [details] [diff] [review]
[ffmpeg] Request YUVJ420P format explicitly. r=kentuckyfriedtakahe, a=sylvestre

[Triage Comment]
Yes, should be in 45 beta 9

Comment 25

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-beta/rev/0a37bbe7d7ab