1247078 - [trychooser] Don't run any jobs if no try syntax is detected

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Andrew Halberstadt [:ahal]]

See:
https://dxr.mozilla.org/build-central/source/buildbotcustom/misc_scheduler.py#23

If there is no 'try:' in the message, trychooser will run the default set. Instead, we want it to run nothing, see bug 1247072 comment 0 for an explanation why.

Comment 1

[Andrew Halberstadt [:ahal]]

Attachment: Don't schedule anything if there is no try syntax

Please assume I have no idea what I'm doing. I also don't know how to test this. Feel free to defer the review if appropriate.

Comment 2

[Phil Ringnalda (:philor)]

It does have tox tests, including http://mxr.mozilla.org/build/source/buildbotcustom/test/test_try_parser.py#151 which expects "" to produce something other than what you're producing.

Comment 3

[Andrew Halberstadt [:ahal]]

Attachment: Don't schedule anything if there is no try syntax

Thanks, updated the test.

Comment 4

[Chris AtLee [:catlee]]

Do we want nothing to happen when no try syntax is detected, or when 'try: none' is specified?

Comment 5

[Phil Ringnalda (:philor)]

There's also "try: ", which I think is something that Old People use as a substitute for "try: -a".

Comment 6

[Andrew Halberstadt [:ahal]]

Yes for the case where there is no try syntax, nothing should happen.

I don't personally care about the invalid try syntax case. All of 'try: none', 'try: ' and 'try: -a' fall under the invalid syntax path, which currently means the default set will be run (which is everything). My intention with this patch was to leave that case alone, but if you'd prefer that an invalid syntax also does nothing, I can change it.

(Aside: the only way to actually run nothing currently is by doing 'try: -b o -p invalid_platform -u none -t none')

Comment 7

[Andrew Halberstadt [:ahal]]

https://hg.mozilla.org/build/buildbotcustom/rev/46fb74d54d79

Not really sure when the bugs get marked closed for this repo.. I'll assume after a reconfig.

Comment 8

[Phil Ringnalda (:philor)]

Correct - if you're lucky there'll be an "in production..." comment.

Comment 9

[Release Engineering SlaveAPI Service]

In production: https://hg.mozilla.org/build/buildbotcustom/rev/46fb74d54d79