Closed
Bug 1247258
Opened 8 years ago
Closed 8 years ago
Use Array.prototype.includes in Telemetry code
Categories
(Toolkit :: Telemetry, defect, P1)
Toolkit
Telemetry
Tracking
()
RESOLVED
FIXED
mozilla47
Tracking | Status | |
---|---|---|
firefox47 | --- | fixed |
People
(Reporter: gfritzsche, Assigned: gfritzsche)
Details
(Whiteboard: [measurement:client])
Attachments
(1 file, 2 obsolete files)
5.66 KB,
patch
|
gfritzsche
:
review+
|
Details | Diff | Splinter Review |
Use Array.prototype.includes in Telemetry code
Assignee | ||
Comment 1•8 years ago
|
||
We have Array.prototype.includes since Fx 43, which is much more readable than the previous a.indexOf(b) based idiom.
Attachment #8717883 -
Flags: review?(alessio.placitelli)
Assignee | ||
Updated•8 years ago
|
Points: --- → 1
Priority: -- → P1
Whiteboard: [measurement:client]
Assignee | ||
Comment 2•8 years ago
|
||
Attachment #8717884 -
Flags: review?(alessio.placitelli)
Assignee | ||
Updated•8 years ago
|
Attachment #8717883 -
Attachment is obsolete: true
Attachment #8717883 -
Flags: review?(alessio.placitelli)
Updated•8 years ago
|
Attachment #8717884 -
Flags: review?(alessio.placitelli) → review+
Comment 3•8 years ago
|
||
There's only one occurrence in the tests, in case you want to take care of that one as well: https://dxr.mozilla.org/mozilla-central/source/toolkit/components/telemetry/tests/unit/test_TelemetryEnvironment.js#409
Assignee | ||
Comment 4•8 years ago
|
||
Assignee | ||
Updated•8 years ago
|
Attachment #8717884 -
Attachment is obsolete: true
Assignee | ||
Updated•8 years ago
|
Attachment #8717891 -
Flags: review+
Comment 6•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/743097ee7470
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox47:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in
before you can comment on or make changes to this bug.
Description
•