Closed Bug 1247260 Opened 4 years ago Closed 2 months ago

Histogram bucket limit should allow for n_values 100 for enumerated histograms

Categories

(Toolkit :: Telemetry, defect, P5)

defect

Tracking

()

RESOLVED FIXED
mozilla72
Tracking Status
firefox47 --- wontfix
firefox72 --- fixed

People

(Reporter: gfritzsche, Assigned: u566121)

References

(Blocks 1 open bug)

Details

(Whiteboard: [measurement:client])

Attachments

(1 file)

We add +1 to the bucket count for enumerated histograms here:
https://dxr.mozilla.org/mozilla-central/rev/2dfb45d74f42d2a0010696f5fd47c7a7da94cedb/toolkit/components/telemetry/histogram_tools.py#287

We check for the bucket count not exceeding 100 here:
https://dxr.mozilla.org/mozilla-central/rev/2dfb45d74f42d2a0010696f5fd47c7a7da94cedb/toolkit/components/telemetry/histogram_tools.py#270

For the other histogram the limit works as expected, but with enumerated histograms the limit triggers with n_values:100 instead of from 101 on.
See Also: → 920169
Assignee: nobody → beatriz.rizental
Attachment #9103526 - Flags: checkin+
Attachment #9103526 - Flags: checkin+
Pushed by jrediger@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3eb9521efab1
Let enumerated and categorical histograms have 100 buckets. r=chutten,frank
Pushed by rgurzau@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ff646e7183a3
Fix lint issue on test_histogramtools_strict.py a=lint-fix CLOSED TREE
Status: NEW → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
You need to log in before you can comment on or make changes to this bug.