Closed
Bug 1247260
Opened 9 years ago
Closed 5 years ago
Histogram bucket limit should allow for n_values 100 for enumerated histograms
Categories
(Toolkit :: Telemetry, defect, P5)
Toolkit
Telemetry
Tracking
()
RESOLVED
FIXED
mozilla72
People
(Reporter: gfritzsche, Assigned: u566121)
References
(Blocks 1 open bug)
Details
(Whiteboard: [measurement:client])
Attachments
(1 file)
We add +1 to the bucket count for enumerated histograms here:
https://dxr.mozilla.org/mozilla-central/rev/2dfb45d74f42d2a0010696f5fd47c7a7da94cedb/toolkit/components/telemetry/histogram_tools.py#287
We check for the bucket count not exceeding 100 here:
https://dxr.mozilla.org/mozilla-central/rev/2dfb45d74f42d2a0010696f5fd47c7a7da94cedb/toolkit/components/telemetry/histogram_tools.py#270
For the other histogram the limit works as expected, but with enumerated histograms the limit triggers with n_values:100 instead of from 101 on.
Comment 1•5 years ago
|
||
Updated•5 years ago
|
Keywords: checkin-needed-tb
Updated•5 years ago
|
Assignee: nobody → beatriz.rizental
Updated•5 years ago
|
Keywords: checkin-needed-tb
Updated•5 years ago
|
Attachment #9103526 -
Flags: checkin+
Updated•5 years ago
|
Attachment #9103526 -
Flags: checkin+
Pushed by jrediger@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3eb9521efab1
Let enumerated and categorical histograms have 100 buckets. r=chutten,frank
Pushed by rgurzau@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ff646e7183a3
Fix lint issue on test_histogramtools_strict.py a=lint-fix CLOSED TREE
Comment 4•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/3eb9521efab1
https://hg.mozilla.org/mozilla-central/rev/ff646e7183a3
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox72:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
Updated•5 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•