native OS X colorpicker from <input type="color"> does not deal with system colors

RESOLVED FIXED in Firefox 51

Status

()

Core
Widget: Cocoa
P3
normal
RESOLVED FIXED
2 years ago
a year ago

People

(Reporter: glazou, Unassigned)

Tracking

unspecified
mozilla51
x86_64
Mac OS X
Points:
---

Firefox Tracking Flags

(firefox51 fixed)

Details

(Whiteboard: tpi:+)

Attachments

(1 attachment)

(Reporter)

Description

2 years ago
When a native OS X colorpicker is opened from a click on a <input type="color">,
a color selection in the NSNamedColorSpace color space is never handled.
To verify that, open such a colorpicker, switch to the "Color Palettes" tab,
select "Developer" in the dropdown and click any system color.

The fix is pretty simple and requires a conversion in nsColorPicker::Update.

I understand a fix there will only select the RGB value of the chosen system
color *at the time of the selection* but that's still better than no result
at all.
(Reporter)

Comment 1

2 years ago
Created attachment 8718030 [details] [diff] [review]
trivial fix
for investigation
Priority: -- → P1
Whiteboard: tpi:+

Updated

a year ago
Priority: P1 → P3
Comment on attachment 8718030 [details] [diff] [review]
trivial fix

Looks good to me. Not sure why you didn't request review.
Attachment #8718030 - Flags: review+

Comment 4

a year ago
Pushed by mstange@themasta.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bd03c5af655d
Correctly handle colors from named color spaces in the native color picker. r=mstange

Comment 5

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/bd03c5af655d
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox51: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
See Also: → bug 1293593
You need to log in before you can comment on or make changes to this bug.