1247373 - native OS X colorpicker from <input type="color"> does not deal with system colors

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect, P3)

Description

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

When a native OS X colorpicker is opened from a click on a <input type="color">,
a color selection in the NSNamedColorSpace color space is never handled.
To verify that, open such a colorpicker, switch to the "Color Palettes" tab,
select "Developer" in the dropdown and click any system color.

The fix is pretty simple and requires a conversion in nsColorPicker::Update.

I understand a fix there will only select the RGB value of the chosen system
color *at the time of the selection* but that's still better than no result
at all.

Comment 1

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

Attachment: trivial fix

Comment 2

[Jim Mathies [:jimm]]

for investigation

Comment 3

[Markus Stange [:mstange]]

Comment on attachment 8718030 [details] [diff] [review]
trivial fix

Looks good to me. Not sure why you didn't request review.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bd03c5af655d
Correctly handle colors from named color spaces in the native color picker. r=mstange

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/bd03c5af655d