Closed
Bug 1247382
Opened 9 years ago
Closed 9 years ago
Improve naming of Linux64 debug tasks
Categories
(Testing :: General, defect)
Testing
General
Tracking
(firefox47 fixed)
RESOLVED
FIXED
mozilla47
Tracking | Status | |
---|---|---|
firefox47 | --- | fixed |
People
(Reporter: armenzg, Unassigned)
References
Details
Attachments
(2 files)
5.81 KB,
patch
|
jmaher
:
review+
|
Details | Diff | Splinter Review |
11.54 KB,
patch
|
jmaher
:
review+
jmaher
:
feedback+
|
Details | Diff | Splinter Review |
jmaher has a script to analyze runs of jobs between TaskCluster and Buildbot.
Unfortunately, he had to do some hacking of the naming to match the jobs [1]
[1] https://github.com/jmaher/randomtools/blob/master/newplatform/timeint.py#L50
Attachment #8718039 -
Flags: review?(jmaher)
Reporter | ||
Comment 1•9 years ago
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8718039 [details] [diff] [review]
Improve naming
Review of attachment 8718039 [details] [diff] [review]:
-----------------------------------------------------------------
thank you!
Attachment #8718039 -
Flags: review?(jmaher) → review+
Reporter | ||
Comment 3•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/99f919028de4105680f223dad86168525d0a7d3b
Bug 1247382 - Improve naming of TaskCluster Linux64 debug jobs. DONTBUILD. r=jmaher
Reporter | ||
Comment 4•9 years ago
|
||
Comment 5•9 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox47:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
Reporter | ||
Updated•9 years ago
|
Reporter | ||
Comment 6•9 years ago
|
||
For the tool I'm building, I want to make sure that every job has chunk defined in the name.
In the near future, I would like to add a check for the decision task to ensure this.
I've tried to normalize a bit more the names with this patch.
These are the actual differences (from grep -h "name: '\[TC" fx_linux64_* | sort):
@@ -6 +6 @@
- name: '[TC] Linux64 jittest'
+ name: '[TC] Linux64 jittest-{{chunk}}'
@@ -12,6 +12,6 @@
- name: '[TC] Linux64 mochitest-browser-chrome'
- name: '[TC] Linux64 mochitest-chrome {{chunk}}'
- name: '[TC] Linux64 mochitest {{chunk}}'
- name: '[TC] Linux64 mochitest-devtools-chrome'
- name: '[TC] Linux64 mochitest-devtools-chrome e10s M(dt{{chunk}})'
- name: '[TC] Linux64 mochitest-e10s-browser-chrome'
+ name: '[TC] Linux64 mochitest-browser-chrome-{{chunk}}'
+ name: '[TC] Linux64 mochitest-browser-chrome-e10s-{{chunk}}'
+ name: '[TC] Linux64 mochitest-chrome -{chunk}}'
+ name: '[TC] Linux64 mochitest-{{chunk}}'
+ name: '[TC] Linux64 mochitest-devtools-chrome-{{chunk}}'
+ name: '[TC] Linux64 mochitest-devtools-chrome-e10s-{{chunk}}'
@@ -20 +20 @@
- name: '[TC] Linux64 mochitest-plain e10s {{chunk}}'
+ name: '[TC] Linux64 mochitest-plain-e10s-{{chunk}}'
@@ -22,5 +22,5 @@
- name: '[TC] Linux64 reftest {{chunk}}'
- name: '[TC] Linux64 reftest {{chunk}}'
- name: '[TC] Linux64 reftest e10s {{chunk}}'
- name: '[TC] Linux64 web-platform-tests {{chunk}}'
- name: '[TC] Linux64 web-platform-tests-e10s {{chunk}}'
+ name: '[TC] Linux64 reftest-{{chunk}}'
+ name: '[TC] Linux64 reftest-{{chunk}}'
+ name: '[TC] Linux64 reftest-e10s-{{chunk}}'
+ name: '[TC] Linux64 web-platform-tests-{{chunk}}'
+ name: '[TC] Linux64 web-platform-tests-e10s-{{chunk}}'
@@ -29 +29 @@
- name: '[TC] Linux64 xpcshell {{chunk}}'
+ name: '[TC] Linux64 xpcshell-{{chunk}}'
Attachment #8718961 -
Flags: feedback?(jmaher)
Comment 7•9 years ago
|
||
Comment on attachment 8718961 [details] [diff] [review]
changes.diff
Review of attachment 8718961 [details] [diff] [review]:
-----------------------------------------------------------------
::: testing/taskcluster/tasks/tests/fx_linux64_mochitest_bc_e10s.yml
@@ +12,5 @@
> scopes:
> - 'docker-worker:capability:device:loopbackVideo'
> - 'docker-worker:capability:device:loopbackAudio'
> metadata:
> + name: '[TC] Linux64 mochitest-browser-chrome-e10s-{{chunk}}'
why is e10s swapped here?
::: testing/taskcluster/tasks/tests/fx_linux64_mochitest_chrome.yml
@@ +4,5 @@
> scopes:
> - 'docker-worker:capability:device:loopbackVideo'
> - 'docker-worker:capability:device:loopbackAudio'
> metadata:
> + name: '[TC] Linux64 mochitest-chrome -{chunk}}'
please cleanup this:
* space before the -
* need two {
Attachment #8718961 -
Flags: feedback?(jmaher) → feedback+
Reporter | ||
Comment 8•9 years ago
|
||
> > + name: '[TC] Linux64 mochitest-browser-chrome-e10s-{{chunk}}'
>
> why is e10s swapped here?
All other e10s jobs follow that pattern 'suite-e10s-{{chunk}}'
Comment 9•9 years ago
|
||
nice- keeping consistent will be great!
Reporter | ||
Comment 10•9 years ago
|
||
Reporter | ||
Comment 11•9 years ago
|
||
Comment on attachment 8718961 [details] [diff] [review]
changes.diff
Review of attachment 8718961 [details] [diff] [review]:
-----------------------------------------------------------------
I forgot to ask for review!
Attachment #8718961 -
Flags: review?(jmaher)
Updated•9 years ago
|
Attachment #8718961 -
Flags: review?(jmaher) → review+
Reporter | ||
Comment 12•9 years ago
|
||
Reporter | ||
Comment 13•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/5d65efb34cd5ebdde5f6ff09de25fcb4165820d0
Bug 1247382 - Improve TaskCluster Linux64 debug test names. DONTBUILD. r=jmaher
Comment 14•9 years ago
|
||
bugherder |
Reporter | ||
Updated•9 years ago
|
Status: REOPENED → RESOLVED
Closed: 9 years ago → 9 years ago
Resolution: --- → FIXED
Comment 15•7 years ago
|
||
Removing leave-open keyword from resolved bugs, per :sylvestre.
Keywords: leave-open
You need to log in
before you can comment on or make changes to this bug.
Description
•