1247413 - Give JS::ubi::BreadthFirst handlers a non-const reference

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Comment 1

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Attachment: Give JS::ubi::BreadthFirst handlers a non-const reference

Comment 2

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=91682b975725

Comment 3

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=b747423002a5

Comment 4

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Woops ignore that second try push

Comment 5

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Ok here is a try push with just this commit and running the proper tests: https://treeherder.mozilla.org/#/jobs?repo=try&revision=deaca74d6147

Comment 6

[Jim Blandy :jimb]

Comment on attachment 8718077 [details] [diff] [review]
Give JS::ubi::BreadthFirst handlers a non-const reference

Review of attachment 8718077 [details] [diff] [review]:
-----------------------------------------------------------------

It worries me a bit that there's nothing in Edge that suggests that one might move names out of it. Could we include the following comment above Edge::name?

// You can take ownership of this name simply by moving out of it; it's a UniquePtr.

Comment 7

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Attachment: Give JS::ubi::BreadthFirst handlers a non-const reference

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4bd47d41528a

Comment 9

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/4bd47d41528a