Give JS::ubi::BreadthFirst handlers a non-const reference

RESOLVED FIXED in Firefox 47

Status

()

defect
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: fitzgen, Assigned: fitzgen)

Tracking

unspecified
mozilla47
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox47 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

No description provided.
Ok here is a try push with just this commit and running the proper tests: https://treeherder.mozilla.org/#/jobs?repo=try&revision=deaca74d6147
Comment on attachment 8718077 [details] [diff] [review]
Give JS::ubi::BreadthFirst handlers a non-const reference

Review of attachment 8718077 [details] [diff] [review]:
-----------------------------------------------------------------

It worries me a bit that there's nothing in Edge that suggests that one might move names out of it. Could we include the following comment above Edge::name?

// You can take ownership of this name simply by moving out of it; it's a UniquePtr.
Attachment #8718077 - Flags: review?(jimb) → review+
Attachment #8718077 - Attachment is obsolete: true
https://hg.mozilla.org/mozilla-central/rev/4bd47d41528a
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in before you can comment on or make changes to this bug.