1247443 - Monitor browser.tabs.animate in telemetry

Status: RESOLVED FIXED

(Toolkit :: Telemetry, defect)

Description

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

We record some pref values in the telemetry ping here:
https://dxr.mozilla.org/mozilla-central/source/toolkit/components/telemetry/TelemetryEnvironment.jsm#96

I would like to start recording browser.tabs.animate to see how important bug 1247137 is.

Comment 1

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Attachment: patch

Comment 2

[Georg Fritzsche [:gfritzsche]]

Comment on attachment 8718156 [details] [diff] [review]
patch

This looks fine.
Forwarding to Benjamin for data collection review [0].

0: https://wiki.mozilla.org/Firefox/Data_Collection

Comment 3

[Georg Fritzsche [:gfritzsche]]

Comment on attachment 8718156 [details] [diff] [review]
patch

Actually - this looks like a measurement we want to collect temporarily and that does not need to trigger a new ping.
This is better recorded as a flag histogram with "expires_in_version" set.
That way you also get dashboarding on telemetry.mozilla.org.

Comment 4

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

How would I do that so that I record one hit per session? i.e., when would I call |add| on the histogram?

> This is better recorded as a flag histogram with "expires_in_version" set.

I think it would be generally useful to know the value of this pref.

> That way you also get dashboarding on telemetry.mozilla.org.

I don't mind analyzing the data myself.

Comment 5

[Georg Fritzsche [:gfritzsche]]

(In reply to Bill McCloskey (:billm) from comment #4)
> > This is better recorded as a flag histogram with "expires_in_version" set.
> 
> I think it would be generally useful to know the value of this pref.

Benjamin, are you ok with recording the pref value of "browser.tabs.animate" in the environment long-term (and make it trigger session splits)?

Comment 6

[Benjamin Smedberg]

This pref is not exposed anywhere in our preferences UI, correct? Do we intend to keep supporting the non-default config?

I don't mind collecting this as long as somebody is going to actually use it, but I suspect it just doesn't matter because we'd probably choose to WONTFIX bugs in this config anyway.

Comment 7

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

(In reply to Benjamin Smedberg  [:bsmedberg] from comment #6)
> This pref is not exposed anywhere in our preferences UI, correct? Do we
> intend to keep supporting the non-default config?
> 
> I don't mind collecting this as long as somebody is going to actually use
> it, but I suspect it just doesn't matter because we'd probably choose to
> WONTFIX bugs in this config anyway.

Add-ons like Classic Theme Restorer set this pref. I don't know how common it is though. That's the reason we want telemetry.

Comment 8

[Georg Fritzsche [:gfritzsche]]

Comment on attachment 8718156 [details] [diff] [review]
patch

Review of attachment 8718156 [details] [diff] [review]:
-----------------------------------------------------------------

To not block on me here - this is fine code-wise.

Comment 9

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/771d182ab98c

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/771d182ab98c

Comment 11

[Jim Mathies [:jimm]]

Comment on attachment 8718156 [details] [diff] [review]
patch

Approval Request Comment
[Feature/regressing bug #]:
no bug, pref settings accumulation for telemetry environment.
[User impact if declined]:
none
[Describe test coverage new/current, TreeHerder]:
on mc for a couple weeks.
[Risks and why]: 
none.
[String/UUID change made/needed]:
none.

Comment 12

[Jim Mathies [:jimm]]

Chris, any chance you can help us out here by pulling the current data from this on nightly?

Comment 13

[Chris H-C :chutten]

Sure, just let me fire up a cluster (leaving ni? up for the nonce)

Comment 14

[Chris H-C :chutten]

Analysis: https://gist.github.com/chutten/2a1884b173a75b23567e2ef6575f5855

Of 42562 clients reporting pings on Nightly from 0410 to 0417 we have 317 clients (0.7%) who have the pref set to false, 2 (0.0%) with it set to true, and the rest leaving it default.

wrt bug 1247137, I make no guarantees that this proportion isn't wildly different on other channels. wrt this bug, data's coming in just fine. I see no problems with it being uplifted.

Comment 15

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8718156 [details] [diff] [review]
patch

More telemetry data, data was verified on Nightly (comment 14), Aurora47+

Comment 16

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/563c3a744984