The default bug view has changed. See this FAQ.

tree.inputField's type as autocomplete fails

NEW
Unassigned

Status

()

Toolkit
XUL Widgets
a year ago
a year ago

People

(Reporter: Peter Kehl, Unassigned)

Tracking

({regression})

Trunk
regression
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: dom-triaged)

Attachments

(2 attachments)

1.91 KB, application/vnd.mozilla.xul+xml
Details
1.80 KB, application/x-xpinstall
Details
(Reporter)

Description

a year ago
Created attachment 8718148 [details]
test1.xul

User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:44.0) Gecko/20100101 Firefox/44.0
Build ID: 20160123151951

Steps to reproduce:

1. Open the attached test1.xul in Firefox.
2. Open Browser Console.
3. Double-click at either cell and start typing 'http' or any recent URL that you visited. It will give you a dropdown autocomplete list.
4. Select any URL.
5. Hit ENTER.
6. In Browser Console, you'll get TypeError: this.tree.view is null, with stack:
set_selectedIndex()  autocomplete.xml:743
detachController() autocomplete.xml:350
onxblblur() autocomplete.xml:653
_handleEnter() tree.xml:668
onxblkeydown() tree.xml:741

At other situations, Firefox shows a popup with similar errors.

This is not specific to 'autocompletesearch' being "history". The problem exists with custom 'autocompletesearch' components, too.

This problem also exists in Firefox release 44.0. This code used to work about half a year ago, but it fails in recent versions of Firefox.

Background: This example (making a tree's cell use autocomplete) may seem exotic. However, it comes from real-world extension that enhances Selenium IDE: https://addons.mozilla.org/en-US/firefox/addon/selite-clipboard-and-indent/.
Component: Untriaged → XUL
Product: Firefox → Core

Updated

a year ago
Keywords: regressionwindow-wanted

Comment 1

a year ago
There are 2 regression/progression.
#1 mouse click on the list works, but I cannot select the list by keyboard(up/down arrow) since Firefox30
Regression window:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=9ce7c3a70c13&tochange=ada4aec5053f
Regressed by: Bug 950373


#2 Partially progression: I can select the list by keyboard(up/down arrow), but hit ENTER causes the Error since Firefox32
Partially progression window:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=8475dbade7b3&tochange=10c6ee2c7524
Partially progressed by: Bug 777832
Blocks: 950373, 777832
Status: UNCONFIRMED → NEW
Ever confirmed: true
Keywords: regressionwindow-wanted → regression
Version: 47 Branch → Trunk

Comment 2

a year ago
Created attachment 8718338 [details]
Bug 1247476.xpi,  simple addon to test

Updated

a year ago
Flags: needinfo?(masayuki)
(Reporter)

Comment 3

a year ago
A variation:
- double-click at the cell
- start typing anything (regardless whether there is a match or not)
- hit ESC
- no alert, but Browser Console shows:
TypeError: this.tree.view is null
set_selectedIndex() autocomplete.xml:724
detachController() autocomplete.xml:348
onxblblur() autocomplete.xml:634
onxblkeydown() tree.xml:746

A related different error:
- double-click at the cell
- don't type anything
- hit ESC
- no alert, but Browser Console shows: 
ReferenceError: reference to undefined property this.popup.popupOpen autocomplete.xml:94:1
(Reporter)

Comment 4

a year ago
Clarification:
My last two stack traces were from Firefox 44.0, not from Firefox 47.0a1. However, the errors reproduce in Firefox 47.0a1, too.
Whiteboard: dom-triaged
(In reply to Alice0775 White from comment #1)
> There are 2 regression/progression.
> #1 mouse click on the list works, but I cannot select the list by
> keyboard(up/down arrow) since Firefox30
> Regression window:
> https://hg.mozilla.org/integration/mozilla-inbound/
> pushloghtml?fromchange=9ce7c3a70c13&tochange=ada4aec5053f
> Regressed by: Bug 950373

This means that the handler listens keypress events. We should change it to keydown.

> #2 Partially progression: I can select the list by keyboard(up/down arrow),
> but hit ENTER causes the Error since Firefox32
> Partially progression window:
> https://hg.mozilla.org/integration/mozilla-inbound/
> pushloghtml?fromchange=8475dbade7b3&tochange=10c6ee2c7524
> Partially progressed by: Bug 777832

I have no idea. I guess I hit a hidden bug which exists before the fix.
Flags: needinfo?(masayuki)

Comment 6

a year ago
(In reply to Masayuki Nakano [:masayuki] (Mozilla Japan) from comment #5)
> (In reply to Alice0775 White from comment #1)
> > There are 2 regression/progression.
> > #1 mouse click on the list works, but I cannot select the list by
> > keyboard(up/down arrow) since Firefox30
> > Regression window:
> > https://hg.mozilla.org/integration/mozilla-inbound/
> > pushloghtml?fromchange=9ce7c3a70c13&tochange=ada4aec5053f
> > Regressed by: Bug 950373
> 
> This means that the handler listens keypress events. We should change it to
> keydown.
> 
> > #2 Partially progression: I can select the list by keyboard(up/down arrow),
> > but hit ENTER causes the Error since Firefox32
> > Partially progression window:
> > https://hg.mozilla.org/integration/mozilla-inbound/
> > pushloghtml?fromchange=8475dbade7b3&tochange=10c6ee2c7524
> > Partially progressed by: Bug 777832
> 
> I have no idea. I guess I hit a hidden bug which exists before the fix.

Yes, the existing bug is caused by Bug 950373.
STR:
1. Type h
2. Select autocomplete list by mouse hover it instead up/down arrow
3. Hit Enter

Actual Results:
TypeError: this.tree.view is null
Flags: needinfo?(masayuki)

Updated

a year ago
No longer blocks: 777832
I'm not sure what you're asking me with the previous comment, though.

Unfortunately, I don't have much time to work on this now. I'm working on rewriting shortcut key mechanism in all desktop platform's widgets and e10s-TSF related bugs as used to be. If you think that this should be fixed as soon as possible, please look for a good person who is aware of autocomplete module. The fix must be simple if somebody know where is the handler.

I think that I'm busy at least until late March. (But you're welcome of notifying me of bugs which I can comment or fix easy, of course.)
Flags: needinfo?(masayuki)

Updated

a year ago
Component: XUL → XUL Widgets
Product: Core → Toolkit
You need to log in before you can comment on or make changes to this bug.