1247531 - Annotate intentional switch fallthrough to suppress -Wimplicit-fallthrough warning in dom/animations/

Status: RESOLVED FIXED

(Core :: DOM: Animation, defect)

Description

[Chris Peterson [:cpeterson]]

Attachment: MOZ_FALLTHROUGH_dom-animation.patch

clang's -Wimplicit-fallthrough warnings (not yet enabled in mozilla-central) warn about switch cases that fall through without a break or return statement. MOZ_FALLTHROUGH (bug 1215411) is an annotation to suppress -Wimplicit-fallthrough warnings where the fallthrough is intentional.

dom/animation/AnimationUtils.cpp:73:9: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough]

Comment 1

[Daniel Holbert [:dholbert]]

Comment on attachment 8718225 [details] [diff] [review]
MOZ_FALLTHROUGH_dom-animation.patch

Review of attachment 8718225 [details] [diff] [review]:
-----------------------------------------------------------------

r=me

Comment 2

[Chris Peterson [:cpeterson]]

Thanks!

Comment 3

[Hiroyuki Ikezoe (:hiro)]

Thank you, Chris and Daniel!  I did not know MOZ_FALLTHROUGH at all.  I will be careful from now on.

Comment 4

[Chris Peterson [:cpeterson]]

(In reply to Hiroyuki Ikezoe (:hiro) from comment #3)
> Thank you, Chris and Daniel!  I did not know MOZ_FALLTHROUGH at all.  I will
> be careful from now on.

That's because I haven't advertised it yet. :) I wanted to fix the remaining warnings (and enable -Wimplicit-fallthrough by default) before I tell more people.

Note that MOZ_FALLTHROUGH is only needed on switch cases that have code:

  switch (foo) {
    case 1: // These cases have no code. No fallthrough annotations are needed.
    case 2:
    case 3:
      foo = 4; // This case has code, so a fallthrough annotation is needed:
      MOZ_FALLTHROUGH;
    default:
      return foo;
  }

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/32fdffe79bd3

Comment 6

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/32fdffe79bd3