Closed
Bug 1247532
Opened 9 years ago
Closed 9 years ago
Annotate intentional switch fallthrough to suppress -Wimplicit-fallthrough warning in dom/canvas/
Categories
(Core :: Graphics: CanvasWebGL, defect)
Core
Graphics: CanvasWebGL
Tracking
()
RESOLVED
FIXED
mozilla47
| Tracking | Status | |
|---|---|---|
| firefox47 | --- | fixed |
People
(Reporter: cpeterson, Assigned: cpeterson)
References
Details
Attachments
(1 file)
|
1.02 KB,
patch
|
jgilbert
:
review+
|
Details | Diff | Splinter Review |
| Comment hidden (obsolete) |
|
Assignee | |
Comment 1•9 years ago
|
||
Comment on attachment 8718226 [details] [diff] [review]
MOZ_FALLTHROUGH_dom-canvas.patch
clang's -Wimplicit-fallthrough warnings (not yet enabled in mozilla-central) warn about switch cases that fall through without a break or return statement. MOZ_FALLTHROUGH (bug 1215411) is an annotation to suppress -Wimplicit-fallthrough warnings where the fallthrough is intentional.
dom/canvas/WebGLContextGL.cpp:845:9: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough]
Attachment #8718226 -
Flags: review?(jgilbert) → review?(dglastonbury)
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8718226 [details] [diff] [review]
MOZ_FALLTHROUGH_dom-canvas.patch
Review of attachment 8718226 [details] [diff] [review]:
-----------------------------------------------------------------
I can take this one.
Attachment #8718226 -
Flags: review?(dglastonbury) → review+
|
||
Comment 5•9 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in
before you can comment on or make changes to this bug.