Closed Bug 1247532 Opened 4 years ago Closed 4 years ago

Annotate intentional switch fallthrough to suppress -Wimplicit-fallthrough warning in dom/canvas/

Categories

(Core :: Canvas: WebGL, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla47
Tracking Status
firefox47 --- fixed

People

(Reporter: cpeterson, Assigned: cpeterson)

References

Details

Attachments

(1 file)

Comment on attachment 8718226 [details] [diff] [review]
MOZ_FALLTHROUGH_dom-canvas.patch

clang's -Wimplicit-fallthrough warnings (not yet enabled in mozilla-central) warn about switch cases that fall through without a break or return statement. MOZ_FALLTHROUGH (bug 1215411) is an annotation to suppress -Wimplicit-fallthrough warnings where the fallthrough is intentional.

dom/canvas/WebGLContextGL.cpp:845:9: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough]
Attachment #8718226 - Flags: review?(jgilbert) → review?(dglastonbury)
Comment on attachment 8718226 [details] [diff] [review]
MOZ_FALLTHROUGH_dom-canvas.patch

Review of attachment 8718226 [details] [diff] [review]:
-----------------------------------------------------------------

I can take this one.
Attachment #8718226 - Flags: review?(dglastonbury) → review+
Thanks, Jeff!
https://hg.mozilla.org/mozilla-central/rev/f505516f9239
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
Blocks: 1253170
You need to log in before you can comment on or make changes to this bug.