Let the ruler remain appeared after reloading
Categories
(DevTools :: Inspector, enhancement, P3)
Tracking
(firefox154 fixed)
| Tracking | Status | |
|---|---|---|
| firefox154 | --- | fixed |
People
(Reporter: r_kato, Assigned: nchevobbe)
References
(Regressed 1 open bug)
Details
Attachments
(4 external files, 1 obsolete file)
Comment 1•10 years ago
|
||
Comment 2•10 years ago
|
||
Updated•8 years ago
|
Updated•4 years ago
|
Comment 4•2 years ago
|
||
FWIW, I was bitten/frustrated/enraged by this today...
(Nine years in Internet Time feels like forever! «sigh»)
Even adding a keyboard shortcut would be more efficient than having to reach for the mouse and target the ruler icon every time I [Cmd+Shift+R]-eload a page I'm working on... (I propose Ctrl+Shift+R on Windows and Cmd+Opt+R on the Mac; they parallel Cmd+Opt+I for opening the DevTools panel itself.)
Thanks! :-D
just bumping this one since it's been a year since the last comment, i'm another dev who would greatly appreciate the ruler toggle status being saved between reloads of the same tab, or even being saved globally.
| Assignee | ||
Comment 6•1 year ago
|
||
Updated•5 months ago
|
Comment 7•5 months ago
|
||
While the frontend doesn't need passing the isShown state from the
actor, the tests require to pass it via highlighter's actor's form.
The frontend can derivate the current state by looking at target actor
configuration.
Comment 8•5 months ago
|
||
This will later help retrieve the instance created from early server logic
when the frontend queries rulers/measure highlighters.
Comment 9•5 months ago
|
||
As rulers/measure highlighters may be shown by server logic,
we need to pass the initial "isShown" state to the client.
Comment 10•5 months ago
|
||
It looks like finalize was meant to destroy the highlighter front
and actor, but the actor wasn't destroyed.
Also calling finalize or destroy didn't make much diffence on both
sides.
Stop using "finalize" manually from the frontend, instead rely
on Front's destroy method to emit the oneway+release "finalize"
request, which would destroy both front and actor.
Updated•5 months ago
|
Updated•5 months ago
|
Updated•5 months ago
|
Updated•5 months ago
|
Comment 11•4 months ago
|
||
Comment 12•4 months ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/cfcb6d7b85a6
https://hg.mozilla.org/mozilla-central/rev/00b4ac82143a
https://hg.mozilla.org/mozilla-central/rev/d50654a9c035
https://hg.mozilla.org/mozilla-central/rev/df4474eee813
Updated•3 months ago
|
Description
•