1247556 - Use GMPInfoFileParser in GMPParent::ReadGMPMetaData()

Status: RESOLVED FIXED

(Core :: Audio/Video: GMP, defect)

Description

[Chris Pearce [:cpearce (Not reading bugmail)]]

We can simplify the code to read the GMP info file by using GMPInfoFileParser in GMPParent::ReadGMPMetaData().

Comment 1

[Chris Pearce [:cpearce (Not reading bugmail)]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=7119a5dff6ab

Comment 2

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Use GMPInfoFileParser in GMPParent::ReadGMPMetaData()

Comment 3

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8718280 [details] [diff] [review]
Use GMPInfoFileParser in GMPParent::ReadGMPMetaData()

Review of attachment 8718280 [details] [diff] [review]:
-----------------------------------------------------------------

r+. Sorry, had to complain about something:

::: dom/media/gmp/GMPUtils.cpp
@@ +181,3 @@
>      ToLowerCase(key);
>      key.Trim(" ");
> +    

Remove spaces on empty lines.

Comment 4

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8718280 [details] [diff] [review]
Use GMPInfoFileParser in GMPParent::ReadGMPMetaData()

Review of attachment 8718280 [details] [diff] [review]:
-----------------------------------------------------------------

Just to be complete:

::: dom/media/gmp/GMPParent.cpp
@@ +738,2 @@
>    }
> +  aOutValue = aParser.Get(aKey);

In most cases, |aParser.Get(aKey)| will be called twice.
But it's not a big cost overall; for a GMP-loading operation that is not time-critical, and (I think) only happens once per plugin per session. So I'm okay with it staying.

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3e2cdc6244d1

Comment 6

[Chris Pearce [:cpearce (Not reading bugmail)]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4cfd6204311e

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3e2cdc6244d1