Sqlite.jsm blobs support

RESOLVED FIXED in Firefox 53

Status

()

Toolkit
Storage
P3
normal
RESOLVED FIXED
a year ago
5 months ago

People

(Reporter: Ilya Gordeev, Assigned: Ilya Gordeev)

Tracking

Trunk
mozilla53
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox53 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment, 3 obsolete attachments)

(Assignee)

Description

a year ago
Created attachment 8718329 [details] [diff] [review]
blobs_support.patch

User Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:36.0) Gecko/20100101 Firefox/36.0
Build ID: 20150305021524

Steps to reproduce:

In Sqlite.jsm there isn't any way to pass into execute function binary data for blob parameter. Proposing patch that adds blobs support.

Updated

a year ago
Component: General → Storage

Updated

a year ago
Attachment #8718329 - Flags: review?(mak77)
Comment on attachment 8718329 [details] [diff] [review]
blobs_support.patch

Review of attachment 8718329 [details] [diff] [review]:
-----------------------------------------------------------------

We can evaluate this addition, but please attach a proper patch format (https://developer.mozilla.org/en-US/docs/Mercurial/Using_Mercurial#How_can_I_generate_a_patch_for_somebody_else_to_check-in_for_me.3F) and add a test to http://mxr.mozilla.org/mozilla-central/source/toolkit/modules/tests/xpcshell/test_sqlite.js for the addition.
Attachment #8718329 - Flags: review?(mak77)
Assignee: nobody → mirraz1
Status: UNCONFIRMED → NEW
Ever confirmed: true
(Assignee)

Comment 2

a year ago
Created attachment 8721451 [details] [diff] [review]
binary_blobs_support.patch
Attachment #8718329 - Attachment is obsolete: true
(Assignee)

Comment 3

a year ago
Created attachment 8721452 [details] [diff] [review]
test_datatypes.patch

Updated

8 months ago
Priority: -- → P3

Updated

5 months ago
Attachment #8721451 - Flags: review?(mak77)

Updated

5 months ago
Attachment #8721452 - Flags: review?(mak77)

Updated

5 months ago
Blocks: 887876
Comment hidden (mozreview-request)

Comment 5

5 months ago
mozreview-review
Comment on attachment 8829105 [details]
Bug 1247602 - Allow to bind blobs in Sqlite.jsm.

https://reviewboard.mozilla.org/r/106302/#review107276

Review in patch form.
Attachment #8829105 - Flags: review?(mak77) → review+

Updated

5 months ago
Attachment #8721451 - Attachment is obsolete: true
Attachment #8721451 - Flags: review?(mak77)

Updated

5 months ago
Attachment #8721452 - Attachment is obsolete: true
Attachment #8721452 - Flags: review?(mak77)

Comment 6

5 months ago
Pushed by mak77@bonardo.net:
https://hg.mozilla.org/integration/autoland/rev/160914d65dac
Allow to bind blobs in Sqlite.jsm. r=mak

Comment 7

5 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/160914d65dac
Status: NEW → RESOLVED
Last Resolved: 5 months ago
status-firefox53: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53

Updated

5 months ago
Depends on: 1336944
You need to log in before you can comment on or make changes to this bug.