Closed
Bug 1247602
Opened 9 years ago
Closed 8 years ago
Sqlite.jsm blobs support
Categories
(Core :: SQLite and Embedded Database Bindings, defect, P3)
Core
SQLite and Embedded Database Bindings
Tracking
()
RESOLVED
FIXED
mozilla53
Tracking | Status | |
---|---|---|
firefox53 | --- | fixed |
People
(Reporter: mirraz1, Assigned: mirraz1)
References
Details
Attachments
(1 file, 3 obsolete files)
User Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:36.0) Gecko/20100101 Firefox/36.0
Build ID: 20150305021524
Steps to reproduce:
In Sqlite.jsm there isn't any way to pass into execute function binary data for blob parameter. Proposing patch that adds blobs support.
Attachment #8718329 -
Flags: review?(mak77)
Comment 1•9 years ago
|
||
Comment on attachment 8718329 [details] [diff] [review]
blobs_support.patch
Review of attachment 8718329 [details] [diff] [review]:
-----------------------------------------------------------------
We can evaluate this addition, but please attach a proper patch format (https://developer.mozilla.org/en-US/docs/Mercurial/Using_Mercurial#How_can_I_generate_a_patch_for_somebody_else_to_check-in_for_me.3F) and add a test to http://mxr.mozilla.org/mozilla-central/source/toolkit/modules/tests/xpcshell/test_sqlite.js for the addition.
Attachment #8718329 -
Flags: review?(mak77)
Updated•9 years ago
|
Assignee: nobody → mirraz1
Status: UNCONFIRMED → NEW
Ever confirmed: true
Assignee | ||
Comment 2•9 years ago
|
||
Attachment #8718329 -
Attachment is obsolete: true
Assignee | ||
Comment 3•9 years ago
|
||
Updated•8 years ago
|
Priority: -- → P3
Updated•8 years ago
|
Attachment #8721451 -
Flags: review?(mak77)
Updated•8 years ago
|
Attachment #8721452 -
Flags: review?(mak77)
Comment hidden (mozreview-request) |
Comment 5•8 years ago
|
||
mozreview-review |
Comment on attachment 8829105 [details]
Bug 1247602 - Allow to bind blobs in Sqlite.jsm.
https://reviewboard.mozilla.org/r/106302/#review107276
Review in patch form.
Attachment #8829105 -
Flags: review?(mak77) → review+
Updated•8 years ago
|
Attachment #8721451 -
Attachment is obsolete: true
Attachment #8721451 -
Flags: review?(mak77)
Updated•8 years ago
|
Attachment #8721452 -
Attachment is obsolete: true
Attachment #8721452 -
Flags: review?(mak77)
Pushed by mak77@bonardo.net:
https://hg.mozilla.org/integration/autoland/rev/160914d65dac
Allow to bind blobs in Sqlite.jsm. r=mak
Comment 7•8 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox53:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Updated•2 months ago
|
Product: Toolkit → Core
You need to log in
before you can comment on or make changes to this bug.
Description
•