Closed
Bug 1247619
Opened 7 years ago
Closed 6 years ago
Warn app devs when they try to use OAuth for STUN
Categories
(Core :: WebRTC: Networking, defect, P1)
Core
WebRTC: Networking
Tracking
()
RESOLVED
FIXED
mozilla47
Tracking | Status | |
---|---|---|
firefox47 | --- | fixed |
backlog | webrtc/webaudio+ |
People
(Reporter: mreavy, Assigned: jib)
References
Details
(Keywords: dev-doc-needed)
Attachments
(1 file)
Add a check to https://dxr.mozilla.org/mozilla-central/source/dom/media/PeerConnection.js#546 for credentialType != “password”. When true, we should warn the app developer that the indicated credentialType is unsupported -- and that credentials will be treated as a password. The warning should cite Bug 1247616 (which will implement OAuth for STUN).
Reporter | ||
Updated•7 years ago
|
backlog: --- → webrtc/webaudio+
Rank: 15
Reporter | ||
Updated•6 years ago
|
Assignee: nobody → jib
Assignee | ||
Comment 1•6 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/36537/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/36537/
Attachment #8723404 -
Flags: review?(rjesup)
Attachment #8723404 -
Flags: review?(bugs)
Comment 2•6 years ago
|
||
Comment on attachment 8723404 [details] MozReview Request: Bug 1247619 - add console warning about OAuth for STUN not yet supported. https://reviewboard.mozilla.org/r/36537/#review33121 r+ for the .webidl
Attachment #8723404 -
Flags: review?(bugs) → review+
Assignee | ||
Comment 3•6 years ago
|
||
Comment on attachment 8723404 [details] MozReview Request: Bug 1247619 - add console warning about OAuth for STUN not yet supported. Review request updated; see interdiff: https://reviewboard.mozilla.org/r/36537/diff/1-2/
Updated•6 years ago
|
Attachment #8723404 -
Flags: review?(rjesup) → review+
Comment 4•6 years ago
|
||
Comment on attachment 8723404 [details] MozReview Request: Bug 1247619 - add console warning about OAuth for STUN not yet supported. https://reviewboard.mozilla.org/r/36537/#review33141
Assignee | ||
Comment 5•6 years ago
|
||
Comment on attachment 8723404 [details] MozReview Request: Bug 1247619 - add console warning about OAuth for STUN not yet supported. Review request updated; see interdiff: https://reviewboard.mozilla.org/r/36537/diff/2-3/
Assignee | ||
Comment 6•6 years ago
|
||
Removed a change that snuck in from another patch.
Comment 8•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/e3235792878f
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox47:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
Updated•3 years ago
|
Keywords: dev-doc-needed
You need to log in
before you can comment on or make changes to this bug.
Description
•