Closed Bug 1247619 Opened 4 years ago Closed 4 years ago

Warn app devs when they try to use OAuth for STUN

Categories

(Core :: WebRTC: Networking, defect, P1)

defect

Tracking

()

RESOLVED FIXED
mozilla47
Tracking Status
firefox47 --- fixed
Blocking Flags:

People

(Reporter: mreavy, Assigned: jib)

References

Details

(Keywords: dev-doc-needed)

Attachments

(1 file)

Add a check to https://dxr.mozilla.org/mozilla-central/source/dom/media/PeerConnection.js#546 for credentialType != “password”.  When true, we should warn the app developer that the indicated credentialType is unsupported -- and that credentials will be treated as a password.  The warning should cite Bug 1247616 (which will implement OAuth for STUN).
backlog: --- → webrtc/webaudio+
Rank: 15
See Also: → 1247616
Assignee: nobody → jib
Comment on attachment 8723404 [details]
MozReview Request: Bug 1247619 - add console warning about OAuth for STUN not yet supported.

https://reviewboard.mozilla.org/r/36537/#review33121

r+ for the .webidl
Attachment #8723404 - Flags: review?(bugs) → review+
Comment on attachment 8723404 [details]
MozReview Request: Bug 1247619 - add console warning about OAuth for STUN not yet supported.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/36537/diff/1-2/
Attachment #8723404 - Flags: review?(rjesup) → review+
Comment on attachment 8723404 [details]
MozReview Request: Bug 1247619 - add console warning about OAuth for STUN not yet supported.

https://reviewboard.mozilla.org/r/36537/#review33141
Comment on attachment 8723404 [details]
MozReview Request: Bug 1247619 - add console warning about OAuth for STUN not yet supported.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/36537/diff/2-3/
Removed a change that snuck in from another patch.
https://hg.mozilla.org/mozilla-central/rev/e3235792878f
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in before you can comment on or make changes to this bug.