1247619 - Warn app devs when they try to use OAuth for STUN

Status: RESOLVED FIXED

(Core :: WebRTC: Networking, defect, P1)

Description

[Maire Reavy [:mreavy] Plz needinfo]

Add a check to https://dxr.mozilla.org/mozilla-central/source/dom/media/PeerConnection.js#546 for credentialType != “password”.  When true, we should warn the app developer that the indicated credentialType is unsupported -- and that credentials will be treated as a password.  The warning should cite Bug 1247616 (which will implement OAuth for STUN).

Comment 1

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Attachment: MozReview Request: Bug 1247619 - add console warning about OAuth for STUN not yet supported.

Review commit: https://reviewboard.mozilla.org/r/36537/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/36537/

Comment 2

[Olli Pettay [:smaug]]

Comment on attachment 8723404 [details]
MozReview Request: Bug 1247619 - add console warning about OAuth for STUN not yet supported.

https://reviewboard.mozilla.org/r/36537/#review33121

r+ for the .webidl

Comment 3

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Comment on attachment 8723404 [details]
MozReview Request: Bug 1247619 - add console warning about OAuth for STUN not yet supported.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/36537/diff/1-2/

Comment 4

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8723404 [details]
MozReview Request: Bug 1247619 - add console warning about OAuth for STUN not yet supported.

https://reviewboard.mozilla.org/r/36537/#review33141

Comment 5

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Comment on attachment 8723404 [details]
MozReview Request: Bug 1247619 - add console warning about OAuth for STUN not yet supported.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/36537/diff/2-3/

Comment 6

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Removed a change that snuck in from another patch.

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e3235792878f

Comment 8

[Wes Kocher (:KWierso)]

https://hg.mozilla.org/mozilla-central/rev/e3235792878f