Closed Bug 1247622 Opened 4 years ago Closed 4 years ago

Make RTCRtpSender.setParameters return a promise.

Categories

(Core :: WebRTC, defect, P1)

defect

Tracking

()

RESOLVED FIXED
mozilla47
Tracking Status
firefox47 --- fixed

People

(Reporter: jib, Assigned: jib)

References

()

Details

Attachments

(1 file)

jib: priority?  perhaps P1/15?  how much work is this?
Flags: needinfo?(jib)
Not much work at all. I was planning on doing it next for bug 1244913, so we have a spec-compliant setParamters out of the gate.
Flags: needinfo?(jib)
Rank: 12
Priority: -- → P1
Comment on attachment 8723321 [details]
MozReview Request: Bug 1247622 - Make RTCRtpSender.setParameters return a promise.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/36485/diff/1-2/
Attachment #8723321 - Flags: review?(bugs)
Comment on attachment 8723321 [details]
MozReview Request: Bug 1247622 - Make RTCRtpSender.setParameters return a promise.

https://reviewboard.mozilla.org/r/36485/#review33075

::: dom/media/tests/mochitest/test_peerConnection_scaleResolution.html:42
(Diff revision 2)
> -      v1.srcObject = stream;
> +      var sender = pc1.addTrack(stream.getVideoTracks()[0], v1.srcObject = stream);

Unless I misunderstand, this doesn't really do more than slightly obfuscate the code (by putting the assignment in an argument).  If there's an advantage that I miss here, fine, otherwise separate it back out.
Attachment #8723321 - Flags: review?(rjesup) → review+
Comment on attachment 8723321 [details]
MozReview Request: Bug 1247622 - Make RTCRtpSender.setParameters return a promise.

https://reviewboard.mozilla.org/r/36485/#review33127

r+ for the .webidl
Attachment #8723321 - Flags: review?(bugs) → review+
https://reviewboard.mozilla.org/r/36485/#review33075

> Unless I misunderstand, this doesn't really do more than slightly obfuscate the code (by putting the assignment in an argument).  If there's an advantage that I miss here, fine, otherwise separate it back out.

whoops, and I have it twice too. I forgot to remove that. thanks for spotting it.
nm, I read comment 5 wrong.
Comment on attachment 8723321 [details]
MozReview Request: Bug 1247622 - Make RTCRtpSender.setParameters return a promise.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/36485/diff/2-3/
https://hg.mozilla.org/mozilla-central/rev/ec4f62653a7e
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in before you can comment on or make changes to this bug.