1247622 - Make RTCRtpSender.setParameters return a promise.

Status: RESOLVED FIXED

(Core :: WebRTC, defect, P1)

Description

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

As of https://github.com/w3c/webrtc-pc/pull/434 setParameters is now async.

Comment 1

[Randell Jesup [:jesup] (needinfo me)]

jib: priority?  perhaps P1/15?  how much work is this?

Comment 2

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Not much work at all. I was planning on doing it next for bug 1244913, so we have a spec-compliant setParamters out of the gate.

Comment 3

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Attachment: MozReview Request: Bug 1247622 - Make RTCRtpSender.setParameters return a promise.

Review commit: https://reviewboard.mozilla.org/r/36485/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/36485/

Comment 4

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Comment on attachment 8723321 [details]
MozReview Request: Bug 1247622 - Make RTCRtpSender.setParameters return a promise.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/36485/diff/1-2/

Comment 5

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8723321 [details]
MozReview Request: Bug 1247622 - Make RTCRtpSender.setParameters return a promise.

https://reviewboard.mozilla.org/r/36485/#review33075

::: dom/media/tests/mochitest/test_peerConnection_scaleResolution.html:42
(Diff revision 2)
> -      v1.srcObject = stream;
> +      var sender = pc1.addTrack(stream.getVideoTracks()[0], v1.srcObject = stream);

Unless I misunderstand, this doesn't really do more than slightly obfuscate the code (by putting the assignment in an argument).  If there's an advantage that I miss here, fine, otherwise separate it back out.

Comment 6

[Olli Pettay [:smaug]]

Comment on attachment 8723321 [details]
MozReview Request: Bug 1247622 - Make RTCRtpSender.setParameters return a promise.

https://reviewboard.mozilla.org/r/36485/#review33127

r+ for the .webidl

Comment 7

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

https://reviewboard.mozilla.org/r/36485/#review33075

> Unless I misunderstand, this doesn't really do more than slightly obfuscate the code (by putting the assignment in an argument).  If there's an advantage that I miss here, fine, otherwise separate it back out.

whoops, and I have it twice too. I forgot to remove that. thanks for spotting it.

Comment 8

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

nm, I read comment 5 wrong.

Comment 9

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Comment on attachment 8723321 [details]
MozReview Request: Bug 1247622 - Make RTCRtpSender.setParameters return a promise.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/36485/diff/2-3/

Comment 10

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ec4f62653a7e

Comment 11

[Wes Kocher (:KWierso)]

https://hg.mozilla.org/mozilla-central/rev/ec4f62653a7e