Closed
Bug 1247622
Opened 9 years ago
Closed 9 years ago
Make RTCRtpSender.setParameters return a promise.
Categories
(Core :: WebRTC, defect, P1)
Core
WebRTC
Tracking
()
RESOLVED
FIXED
mozilla47
Tracking | Status | |
---|---|---|
firefox47 | --- | fixed |
People
(Reporter: jib, Assigned: jib)
References
()
Details
Attachments
(1 file)
As of https://github.com/w3c/webrtc-pc/pull/434 setParameters is now async.
Assignee | ||
Comment 2•9 years ago
|
||
Not much work at all. I was planning on doing it next for bug 1244913, so we have a spec-compliant setParamters out of the gate.
Flags: needinfo?(jib)
Updated•9 years ago
|
Rank: 12
Priority: -- → P1
Assignee | ||
Comment 3•9 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/36485/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/36485/
Attachment #8723321 -
Flags: review?(rjesup)
Assignee | ||
Comment 4•9 years ago
|
||
Comment on attachment 8723321 [details]
MozReview Request: Bug 1247622 - Make RTCRtpSender.setParameters return a promise.
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/36485/diff/1-2/
Assignee | ||
Updated•9 years ago
|
Attachment #8723321 -
Flags: review?(bugs)
Assignee | ||
Updated•9 years ago
|
Comment 5•9 years ago
|
||
Comment on attachment 8723321 [details]
MozReview Request: Bug 1247622 - Make RTCRtpSender.setParameters return a promise.
https://reviewboard.mozilla.org/r/36485/#review33075
::: dom/media/tests/mochitest/test_peerConnection_scaleResolution.html:42
(Diff revision 2)
> - v1.srcObject = stream;
> + var sender = pc1.addTrack(stream.getVideoTracks()[0], v1.srcObject = stream);
Unless I misunderstand, this doesn't really do more than slightly obfuscate the code (by putting the assignment in an argument). If there's an advantage that I miss here, fine, otherwise separate it back out.
Attachment #8723321 -
Flags: review?(rjesup) → review+
Comment 6•9 years ago
|
||
Comment on attachment 8723321 [details]
MozReview Request: Bug 1247622 - Make RTCRtpSender.setParameters return a promise.
https://reviewboard.mozilla.org/r/36485/#review33127
r+ for the .webidl
Attachment #8723321 -
Flags: review?(bugs) → review+
Assignee | ||
Comment 7•9 years ago
|
||
https://reviewboard.mozilla.org/r/36485/#review33075
> Unless I misunderstand, this doesn't really do more than slightly obfuscate the code (by putting the assignment in an argument). If there's an advantage that I miss here, fine, otherwise separate it back out.
whoops, and I have it twice too. I forgot to remove that. thanks for spotting it.
Assignee | ||
Comment 9•9 years ago
|
||
Comment on attachment 8723321 [details]
MozReview Request: Bug 1247622 - Make RTCRtpSender.setParameters return a promise.
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/36485/diff/2-3/
Comment 10•9 years ago
|
||
Comment 11•9 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in
before you can comment on or make changes to this bug.
Description
•