service worker interception does not fail gracefully if FinishResponse runnable hits an error

RESOLVED FIXED in Firefox 47

Status

()

Product:
Core
Component:
DOM: Service Workers
RESOLVED FIXED
Reported:
2 years ago
Modified:
2 years ago

People

(Reporter: bkelly, Assigned: bkelly)

Tracking

Version:
32 Branch
Target:
mozilla47
Points:
---

Firefox Tracking Flags

(firefox47 fixed)

Details

Attachments

(1 attachment)

Cancel intercepted channel in more service worker failure cases. r=jdm
2.05 KB, patch
jdm
: review+
Details | Diff | Splinter Review
(Assignee)

Description

•
2 years ago 
While investigating bug 1247580 I noticed that we have some error paths that do not correctly cancel or reset the intercepted channel.  Specifically, there are some ways the FinishResponse runnable can do this.

I'm not sure if it explains bug 1247580, but we should fix these.
 (Assignee)

Comment 1

•
2 years ago 
Created attachment 8718363 [details] [diff] [review]
Cancel intercepted channel in more service worker failure cases. r=jdm

I considered calling ResetInterception() for these cases since they are internal errors, but I guess its better to surface the issue instead of hiding it.
Attachment #8718363 - Flags: review?(josh)
Attachment #8718363 - Flags: review?(josh) → review+

Comment 3

•
2 years ago
bugherder 
https://hg.mozilla.org/mozilla-central/rev/beb2e1c61e4e
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox47: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in before you can comment on or make changes to this bug.