Closed Bug 1247623 Opened 4 years ago Closed 4 years ago

service worker interception does not fail gracefully if FinishResponse runnable hits an error

Categories

(Core :: DOM: Service Workers, defect)

Product:
Core
Component:
DOM: Service Workers
Version:
32 Branch
Type:
defect
Priority:
Not set

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla47
Tracking Flags:
Tracking Status
firefox47 --- fixed

People

(Reporter: bkelly, Assigned: bkelly)

References

Details

Attachments

(1 file)

Cancel intercepted channel in more service worker failure cases. r=jdm
2.05 KB, patch
jdm
: review+
Details | Diff | Splinter Review 
While investigating bug 1247580 I noticed that we have some error paths that do not correctly cancel or reset the intercepted channel.  Specifically, there are some ways the FinishResponse runnable can do this.

I'm not sure if it explains bug 1247580, but we should fix these.
I considered calling ResetInterception() for these cases since they are internal errors, but I guess its better to surface the issue instead of hiding it.
Attachment #8718363 - Flags: review?(josh)
Attachment #8718363 - Flags: review?(josh) → review+
https://hg.mozilla.org/mozilla-central/rev/beb2e1c61e4e
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox47: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in before you can comment on or make changes to this bug.