1247623 - service worker interception does not fail gracefully if FinishResponse runnable hits an error

Status: RESOLVED FIXED

(Core :: DOM: Service Workers, defect)

Description

[Ben Kelly [:bkelly, not reviewing]]

While investigating bug 1247580 I noticed that we have some error paths that do not correctly cancel or reset the intercepted channel.  Specifically, there are some ways the FinishResponse runnable can do this.

I'm not sure if it explains bug 1247580, but we should fix these.

Comment 1

[Ben Kelly [:bkelly, not reviewing]]

Attachment: Cancel intercepted channel in more service worker failure cases. r=jdm

I considered calling ResetInterception() for these cases since they are internal errors, but I guess its better to surface the issue instead of hiding it.

Comment 2

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/beb2e1c61e4e

Comment 3

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/beb2e1c61e4e