Closed
Bug 1247623
Opened 8 years ago
Closed 8 years ago
service worker interception does not fail gracefully if FinishResponse runnable hits an error
Categories
(Core :: DOM: Service Workers, defect)
Tracking
()
RESOLVED
FIXED
mozilla47
| Tracking | Status | |
|---|---|---|
| firefox47 | --- | fixed |
People
(Reporter: bkelly, Assigned: bkelly)
References
Details
Attachments
(1 file)
|
2.05 KB,
patch
|
jdm
:
review+
|
Details | Diff | Splinter Review |
While investigating bug 1247580 I noticed that we have some error paths that do not correctly cancel or reset the intercepted channel. Specifically, there are some ways the FinishResponse runnable can do this. I'm not sure if it explains bug 1247580, but we should fix these.
|
Assignee | |
Comment 1•8 years ago
|
||
I considered calling ResetInterception() for these cases since they are internal errors, but I guess its better to surface the issue instead of hiding it.
Attachment #8718363 -
Flags: review?(josh)
|
||
Updated•8 years ago
|
Attachment #8718363 -
Flags: review?(josh) → review+
|
||
Comment 3•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/beb2e1c61e4e
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox47:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in
before you can comment on or make changes to this bug.
Description
•