1247637 - crash in android.content.ActivityNotFoundException: at android.app.Instrumentation.checkStartActivityResult(Instrumentation.java)

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Liviu Cirdei]

This bug was filed from the Socorro interface and is 
report bp-0794b8d9-b94a-4be7-81e0-b80482160211.
=============================================================
Steps to reproduce:

1. Open Nightly 47.0a1 on Android device.
2. From Menu go to "Settings".
3. Sign in with a Firefox account and click on your account. 
4. Scroll down and click "Terms of Service" or "Privacy Notice".

Actual Result: Nightly crashes every time.

Expected Result: Terms of Service / Privacy Notice pages open successfully.

Comment 1

[Teodora Vermesan (:TeoVermesan)]

regression window:
mozilla-central:
good build: 05-02-2016
bad build: 06-02-2016

pushlog: http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=1dbe350b57b17ec1ce2887441b79c6f51b429378&tochange=4295f9951e9331a2f2bd0a8ea8c4ad73af141a7b

Comment 2

[Sebastian Kaspari (:sebastian; :pocmo)]

This looks like it's related to the changes in bug 1242213.

Comment 3

[Nick Alexander :nalexander [he/him]]

(In reply to Sebastian Kaspari (:sebastian) from comment #2)
> This looks like it's related to the changes in bug 1242213.

Gah!  You are totally right, I forgot to purge a .App usage.  Thought this went with the Old Sync stuff, but it didn't: https://dxr.mozilla.org/mozilla-central/source/mobile/android/services/strings.xml.in#103.

Comment 4

[Nick Alexander :nalexander [he/him]]

Attachment: MozReview Request: Bug 1247637 - Remove browser_intent_*; use ActivityUtils to open FxA links. r?sebastian

This fixes a crash, since Bug 1242213 removed the .App
<activity-alias> that browser_intent_class references.

I debated just updating the strings, and decided that it was best to
remove a pattern that is used only once in our codebase, even though
it moves more functionality to code.

Review commit: https://reviewboard.mozilla.org/r/34563/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/34563/

Comment 5

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8718419 [details]
MozReview Request: Bug 1247637 - Remove browser_intent_*; use ActivityUtils to open FxA links. r?sebastian

https://reviewboard.mozilla.org/r/34563/#review31247

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/932bf3a8e7ba

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/932bf3a8e7ba

Comment 8

[Teodora Vermesan (:TeoVermesan)]

Verified as fixed using:
Device: Nexus 6 (Android 6.0)
Build: Firefox for Android 47.0a1 (2016-02-14)