Closed Bug 1247656 Opened 4 years ago Closed 4 years ago

Validate that a reoffer does not reorder m-sections, or change their media type

Categories

(Core :: WebRTC: Signaling, defect, P2)

defect

Tracking

()

RESOLVED FIXED
mozilla47
Tracking Status
firefox47 --- fixed
Blocking Flags:

People

(Reporter: bwc, Assigned: bwc)

Details

Attachments

(1 file)

No description provided.
Comment on attachment 8718439 [details]
MozReview Request: Bug 1247656: Make sure that remote reoffer does not change the media type of an m-line. r=drno

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/34575/diff/1-2/
Attachment #8718439 - Attachment description: MozReview Request: Bug 1247656: Make sure that remote reoffer does not change the media type of an m-line. → MozReview Request: Bug 1247656: Make sure that remote reoffer does not change the media type of an m-line. r?drno
Attachment #8718439 - Flags: review?(drno)
Comment on attachment 8718439 [details]
MozReview Request: Bug 1247656: Make sure that remote reoffer does not change the media type of an m-line. r=drno

https://reviewboard.mozilla.org/r/34575/#review31465

LGTM
Attachment #8718439 - Flags: review?(drno) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/d2cb189066ea
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
I had to back this out for apparently causing a spike in ASAN failures in test_browserElement_oop_getWebManifest.html

https://treeherder.mozilla.org/logviewer.html#?job_id=21801214&repo=mozilla-inbound
https://hg.mozilla.org/integration/mozilla-inbound/rev/e3ede55daf7e
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
I would be shocked if this was the true cause of that failure. I would be inclined to suspect bug 1247432 (which landed in the same push), since it deals with cache IO stuff, which is where the ASAN crash occurs.
Comment on attachment 8718439 [details]
MozReview Request: Bug 1247656: Make sure that remote reoffer does not change the media type of an m-line. r=drno

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/34575/diff/2-3/
Attachment #8718439 - Attachment description: MozReview Request: Bug 1247656: Make sure that remote reoffer does not change the media type of an m-line. r?drno → MozReview Request: Bug 1247656: Make sure that remote reoffer does not change the media type of an m-line. r=drno
Not sure of the exact priority; likely doesn't matter as there's a patch already
backlog: --- → webrtc/webaudio+
Rank: 22
Priority: -- → P2
https://hg.mozilla.org/mozilla-central/rev/b0da28952e5b
Status: REOPENED → RESOLVED
Closed: 4 years ago4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.