Closed
Bug 1247656
Opened 10 years ago
Closed 10 years ago
Validate that a reoffer does not reorder m-sections, or change their media type
Categories
(Core :: WebRTC: Signaling, defect, P2)
Core
WebRTC: Signaling
Tracking
()
RESOLVED
FIXED
mozilla47
| Tracking | Status | |
|---|---|---|
| firefox47 | --- | fixed |
| backlog | webrtc/webaudio+ |
People
(Reporter: bwc, Assigned: bwc)
Details
Attachments
(1 file)
No description provided.
|
Assignee | |
Comment 1•10 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/34575/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/34575/
|
|
Assignee | |
Comment 2•10 years ago
|
||
Comment on attachment 8718439 [details]
MozReview Request: Bug 1247656: Make sure that remote reoffer does not change the media type of an m-line. r=drno
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/34575/diff/1-2/
Attachment #8718439 -
Attachment description: MozReview Request: Bug 1247656: Make sure that remote reoffer does not change the media type of an m-line. → MozReview Request: Bug 1247656: Make sure that remote reoffer does not change the media type of an m-line. r?drno
Attachment #8718439 -
Flags: review?(drno)
|
||
Comment 3•10 years ago
|
||
Comment on attachment 8718439 [details]
MozReview Request: Bug 1247656: Make sure that remote reoffer does not change the media type of an m-line. r=drno
https://reviewboard.mozilla.org/r/34575/#review31465
LGTM
Attachment #8718439 -
Flags: review?(drno) → review+
|
|
Assignee | |
Updated•10 years ago
|
Keywords: checkin-needed
Keywords: checkin-needed
|
||
Comment 5•10 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
|
||
Comment 6•10 years ago
|
||
| backout bugherder landing | ||
I had to back this out for apparently causing a spike in ASAN failures in test_browserElement_oop_getWebManifest.html
https://treeherder.mozilla.org/logviewer.html#?job_id=21801214&repo=mozilla-inbound
https://hg.mozilla.org/integration/mozilla-inbound/rev/e3ede55daf7e
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
|
|
Assignee | |
Comment 7•10 years ago
|
||
I would be shocked if this was the true cause of that failure. I would be inclined to suspect bug 1247432 (which landed in the same push), since it deals with cache IO stuff, which is where the ASAN crash occurs.
|
|
Assignee | |
Comment 8•10 years ago
|
||
Comment on attachment 8718439 [details]
MozReview Request: Bug 1247656: Make sure that remote reoffer does not change the media type of an m-line. r=drno
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/34575/diff/2-3/
Attachment #8718439 -
Attachment description: MozReview Request: Bug 1247656: Make sure that remote reoffer does not change the media type of an m-line. r?drno → MozReview Request: Bug 1247656: Make sure that remote reoffer does not change the media type of an m-line. r=drno
|
||
Comment 9•10 years ago
|
||
Not sure of the exact priority; likely doesn't matter as there's a patch already
backlog: --- → webrtc/webaudio+
Rank: 22
Priority: -- → P2
|
||
Comment 10•10 years ago
|
||
|
|
||
Comment 11•10 years ago
|
||
| bugherder | ||
Status: REOPENED → RESOLVED
Closed: 10 years ago → 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•